From patchwork Wed Jan 4 14:44:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 13088665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E09B4C4708D for ; Wed, 4 Jan 2023 14:46:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD51S-0005Fj-39; Wed, 04 Jan 2023 09:45:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD51C-0005Ev-EN for qemu-devel@nongnu.org; Wed, 04 Jan 2023 09:45:26 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD51A-0002oB-Tf for qemu-devel@nongnu.org; Wed, 04 Jan 2023 09:45:26 -0500 Received: by mail-wr1-x429.google.com with SMTP id s9so1187842wru.13 for ; Wed, 04 Jan 2023 06:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8AWtfe719mk9eM2p93lKeuen7Jx5n1pIewca97MBqdc=; b=OwFsjrcMxKj1s4H/fotfYoCBwsygaVEcANDEtkGKlRyfBhRTz2OCJEfvXLHdpvGD7x 1UEQXKL/fkPiuknoLjoM5DN7aY70nsceK2OJjfdaAgw9ncTN9zqwANYNKuVh9/VYPIav Gxa5DzQLOhl4wRP4fdUdJRo0/0J+NooIx+ufMBgihzp8h8ReOBqkfcMdo5OIuU7w6C1T xeIFvIeZUCH0v04IqmRX6RWe7b9aT6myshNL5uBQppaZzdT6fjevlsqcM0Ali9GqYGyM 3aA5vHjcTLoKc3+eO5xe3fGq8g9ZH0qb1jafzvK3ILB8i4T2FQ5zM5m/u/LZkPbBN/GS +UMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8AWtfe719mk9eM2p93lKeuen7Jx5n1pIewca97MBqdc=; b=hXwbEv+gPUBRPJIUAfkJKRNJEoq/RD7VeMMExPLyhweA9nOHrOS21JmDg9LgAFhhW5 m1yDeO7tq8YPJCxWGM+f/wRLqutiNMFNkmZffuvZT6B5CvWzjLXFkrSDQWkYbyPS2wBV tLw5tOpEbyOkQRx/TDOJtPpI6JsYrZvVGyHitpE2GJKFYNN3iQ+4ENyBZSJwhMmiPAiN GQiKcNOhAr4k3tkU99bCXMttn8gJe6FfQX53bn4BpvHMxbwlfALxJDRqcu9UyqdxITKl lo2oo+JGrOQPbs8aV1Km954rznLGuh+ojicOW4I9mtF2BFnUmqSdOMV/tGJMY1BImK9B Objw== X-Gm-Message-State: AFqh2koRAkPyMt8BPgX2+jEA0q941lJT7RVesGaZYl1dl1GhcUpjcwYN +j74KrUW6Dp4KeJdz3jl79BhZ9WyLMlpmw== X-Google-Smtp-Source: AMrXdXvIETTxnaRaRvm9hcFDe31cy8g3McWj56E8OyCHBH1xc4SjLtjj5azN8me5MaQQNXaIHCKkjw== X-Received: by 2002:a5d:5e81:0:b0:244:e704:df2c with SMTP id ck1-20020a5d5e81000000b00244e704df2cmr34565713wrb.57.1672843522692; Wed, 04 Jan 2023 06:45:22 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:22 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?utf-8?q?Herv=C3=A9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Date: Wed, 4 Jan 2023 15:44:31 +0100 Message-Id: <20230104144437.27479-1-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=shentey@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC machine agnostic to the precise southbridge being used. 2/ will become particularily interesting once PIIX4 becomes usable in the PC machine, avoiding the "Frankenstein" use of PIIX4_ACPI in PIIX3. v2: - xen_piix3_set_irq() is already generic. Just rename it. (Chuck) Testing done: None, because I don't know how to conduct this properly :( Based-on: <20221221170003.2929-1-shentey@gmail.com> "[PATCH v4 00/30] Consolidate PIIX south bridges" Bernhard Beschow (6): include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 hw/isa/piix: Avoid Xen-specific variant of piix_write_config() hw/isa/piix: Resolve redundant k->config_write assignments hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE hw/i386/pc_piix.c | 34 ++++++++++++++++-- hw/i386/xen/xen-hvm.c | 2 +- hw/isa/piix.c | 66 +---------------------------------- include/hw/southbridge/piix.h | 1 - include/hw/xen/xen.h | 2 +- stubs/xen-hw-stub.c | 2 +- 6 files changed, 35 insertions(+), 72 deletions(-) Reviewed-by: Michael S. Tsirkin