[v3,0/7] AML Housekeeping

Message

Bernhard Beschow Jan. 16, 2023, 3:29 p.m. UTC

This series resolves the AcpiDeviceIfClass::madt_cpu function pointer. It turns
out that it isn't needed and it even frees the ACPI controllers from assigning
it an x86 specific function. This is especially interesting for the PIIX4 PM
which is also used in MIPS only contexts.

Furthermore, the series introduces qbus_build_aml() which then gets
used to resolve isa_build_aml().

v3:
- Clean up includes in AcpiDeviceIfClass::madt_cpu sub series last (Markus)
- Restructure qbus_build_aml() sub series (Phil, me)

v2:
- Don't inline qbus_build_aml() (Phil)
- Add 'hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"'

Testing done:
* `make check`
* `make check-avocado`
* `qemu-system-x86_64 -M pc -m 2G -cdrom manjaro-kde-21.2.6-220416-linux515.iso`
* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
   manjaro-kde-21.2.6-220416-linux515.iso`

Bernhard Beschow (7):
  hw/acpi/acpi_dev_interface: Remove unused parameter from
    AcpiDeviceIfClass::madt_cpu
  hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu
  hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h"
  hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"
  hw/i386/acpi-build: Remove unused attributes
  hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml()
  piix3, ich9: Reuse qbus_build_aml()

 hw/acpi/hmat.h                       |  3 ++-
 hw/i386/acpi-common.h                |  7 +++++--
 include/hw/acpi/acpi_aml_interface.h |  3 +++
 include/hw/acpi/acpi_dev_interface.h |  4 ----
 include/hw/acpi/cpu.h                |  6 +++++-
 include/hw/i386/pc.h                 |  6 ------
 include/hw/isa/isa.h                 |  1 -
 hw/acpi/acpi-x86-stub.c              |  7 -------
 hw/acpi/acpi_interface.c             | 10 ++++++++++
 hw/acpi/cpu.c                        | 12 +++++-------
 hw/acpi/hmat.c                       |  1 +
 hw/acpi/memory_hotplug.c             |  1 +
 hw/acpi/piix4.c                      |  3 ---
 hw/i2c/smbus_ich9.c                  |  5 +----
 hw/i386/acpi-build.c                 |  7 ++-----
 hw/i386/acpi-common.c                | 10 ++++------
 hw/i386/acpi-microvm.c               |  6 +++---
 hw/i386/generic_event_device_x86.c   |  9 ---------
 hw/isa/isa-bus.c                     | 10 ----------
 hw/isa/lpc_ich9.c                    |  6 +-----
 hw/isa/piix3.c                       |  5 +----
 monitor/qmp-cmds.c                   |  1 +
 22 files changed, 45 insertions(+), 78 deletions(-)