| Message ID | 20230221221818.9382-1-anjo@rev.ng (mailing list archive) |
|---|---|
| Headers | show |
| Series | Replace TARGET_TB_PCREL with CF_PCREL | expand |
On 21/2/23 23:17, Anton Johansson wrote: > This patchset entirely replaces the macro TARGET_TB_PCREL with > a field in TranslationBlock.cflags called CF_PCREL, and is a > first step towards removing target-specific assumptions from > non-target/ directories. > > The grand goal is to allow for heterogeneous QEMU binaries > consisting of multiple frontends. > > RFC: https://lists.nongnu.org/archive/html/qemu-devel/2022-12/msg04518.html > > Changes in v2: > * Setting of CF_PCREL (previously patch 3) was split in two and moved > up front (to patch 2 and 3); > > * Replacing of TARGET_TB_PCREL (previously patch 2) was split into > four patches (patches [4,7]), one for each affected submodule; > > * Removal of TARGET_TB_PCREL (previously patch 3) was moved into > separate patches, one for each submodule (patches [8,10]); > > * Patch 11 was introduced in response to feedback, and removes > CF_PCREL checks in functions in tb-jmp-cache.h, these functions were > always called in a context where CF_PCREL was already being checked. > These tb-jmp-cache.h functions were then removed in favour of manual > inlining; > > * Patches [12,26] replaces calls to tb_pc() with a member access > tb->pc, the motivation being that tb_pc() was (almost) always called > in a context where CF_PCREL was already being checked; > > * Finally patch 27 removes tb_pc() which is no longer used. > > Since changes are spread across multiple submodules we ended up with a > lot of patches. Patches [11,27] still need review. > > Anton Johansson (27): > include/exec: Introduce `CF_PCREL` > target/i386: set `CF_PCREL` in `x86_cpu_realizefn` > target/arm: set `CF_PCREL` in `arm_cpu_realizefn` > accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL` > include/exec: Replace `TARGET_TB_PCREL` with `CF_PCREL` > target/arm: Replace `TARGET_TB_PCREL` with `CF_PCREL` > target/i386: Replace `TARGET_TB_PCREL` with `CF_PCREL` > include/exec: Remove `TARGET_TB_PCREL` define > target/arm: Remove `TARGET_TB_PCREL` define > target/i386: Remove `TARGET_TB_PCREL` define > accel/tcg: Move jmp-cache `CF_PCREL` checks to caller > accel/tcg: Replace `tb_pc()` with `tb->pc` > target/tricore: Replace `tb_pc()` with `tb->pc` > target/sparc: Replace `tb_pc()` with `tb->pc` > target/sh4: Replace `tb_pc()` with `tb->pc` > target/rx: Replace `tb_pc()` with `tb->pc` > target/riscv: Replace `tb_pc()` with `tb->pc` > target/openrisc: Replace `tb_pc()` with `tb->pc` > target/mips: Replace `tb_pc()` with `tb->pc` > target/microblaze: Replace `tb_pc()` with `tb->pc` > target/loongarch: Replace `tb_pc()` with `tb->pc` > target/i386: Replace `tb_pc()` with `tb->pc` > target/hppa: Replace `tb_pc()` with `tb->pc` > target/hexagon: Replace `tb_pc()` with `tb->pc` > target/avr: Replace `tb_pc()` with `tb->pc` > target/arm: Replace `tb_pc()` with `tb->pc` > include/exec: Remove `tb_pc()` Series: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This patchset entirely replaces the macro TARGET_TB_PCREL with a field in TranslationBlock.cflags called CF_PCREL, and is a first step towards removing target-specific assumptions from non-target/ directories. The grand goal is to allow for heterogeneous QEMU binaries consisting of multiple frontends. RFC: https://lists.nongnu.org/archive/html/qemu-devel/2022-12/msg04518.html Changes in v2: * Setting of CF_PCREL (previously patch 3) was split in two and moved up front (to patch 2 and 3); * Replacing of TARGET_TB_PCREL (previously patch 2) was split into four patches (patches [4,7]), one for each affected submodule; * Removal of TARGET_TB_PCREL (previously patch 3) was moved into separate patches, one for each submodule (patches [8,10]); * Patch 11 was introduced in response to feedback, and removes CF_PCREL checks in functions in tb-jmp-cache.h, these functions were always called in a context where CF_PCREL was already being checked. These tb-jmp-cache.h functions were then removed in favour of manual inlining; * Patches [12,26] replaces calls to tb_pc() with a member access tb->pc, the motivation being that tb_pc() was (almost) always called in a context where CF_PCREL was already being checked; * Finally patch 27 removes tb_pc() which is no longer used. Since changes are spread across multiple submodules we ended up with a lot of patches. Patches [11,27] still need review. Anton Johansson (27): include/exec: Introduce `CF_PCREL` target/i386: set `CF_PCREL` in `x86_cpu_realizefn` target/arm: set `CF_PCREL` in `arm_cpu_realizefn` accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL` include/exec: Replace `TARGET_TB_PCREL` with `CF_PCREL` target/arm: Replace `TARGET_TB_PCREL` with `CF_PCREL` target/i386: Replace `TARGET_TB_PCREL` with `CF_PCREL` include/exec: Remove `TARGET_TB_PCREL` define target/arm: Remove `TARGET_TB_PCREL` define target/i386: Remove `TARGET_TB_PCREL` define accel/tcg: Move jmp-cache `CF_PCREL` checks to caller accel/tcg: Replace `tb_pc()` with `tb->pc` target/tricore: Replace `tb_pc()` with `tb->pc` target/sparc: Replace `tb_pc()` with `tb->pc` target/sh4: Replace `tb_pc()` with `tb->pc` target/rx: Replace `tb_pc()` with `tb->pc` target/riscv: Replace `tb_pc()` with `tb->pc` target/openrisc: Replace `tb_pc()` with `tb->pc` target/mips: Replace `tb_pc()` with `tb->pc` target/microblaze: Replace `tb_pc()` with `tb->pc` target/loongarch: Replace `tb_pc()` with `tb->pc` target/i386: Replace `tb_pc()` with `tb->pc` target/hppa: Replace `tb_pc()` with `tb->pc` target/hexagon: Replace `tb_pc()` with `tb->pc` target/avr: Replace `tb_pc()` with `tb->pc` target/arm: Replace `tb_pc()` with `tb->pc` include/exec: Remove `tb_pc()` accel/tcg/cpu-exec.c | 64 +++++++++++++++++-------- accel/tcg/internal.h | 10 ++-- accel/tcg/perf.c | 2 +- accel/tcg/tb-jmp-cache.h | 42 +--------------- accel/tcg/tb-maint.c | 10 ++-- accel/tcg/translate-all.c | 16 +++---- include/exec/cpu-defs.h | 3 -- include/exec/exec-all.h | 21 ++------ target/arm/cpu-param.h | 2 - target/arm/cpu.c | 17 ++++--- target/arm/translate-a64.c | 8 ++-- target/arm/translate.c | 6 +-- target/arm/translate.h | 2 +- target/avr/cpu.c | 3 +- target/hexagon/cpu.c | 4 +- target/hppa/cpu.c | 8 ++-- target/i386/cpu-param.h | 4 -- target/i386/cpu.c | 5 ++ target/i386/helper.c | 2 +- target/i386/tcg/tcg-cpu.c | 8 ++-- target/i386/tcg/translate.c | 26 +++++----- target/loongarch/cpu.c | 6 ++- target/microblaze/cpu.c | 4 +- target/mips/tcg/exception.c | 3 +- target/mips/tcg/sysemu/special_helper.c | 2 +- target/openrisc/cpu.c | 4 +- target/riscv/cpu.c | 7 ++- target/rx/cpu.c | 3 +- target/sh4/cpu.c | 6 ++- target/sparc/cpu.c | 4 +- target/tricore/cpu.c | 3 +- 31 files changed, 152 insertions(+), 153 deletions(-) -- 2.39.1