[v2,0/3] contrib/elf2dmp: Windows Server 2022 support

Message

Viktor Prutyanov Feb. 22, 2023, 9:12 p.m. UTC

Hi,

For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
Windows Server 2022 guest. This patch series fixes it.

v1: improve code-style fix
v2: don't remove data directory entry RVA print and DOS header size check

Viktor Prutyanov (3):
  contrib/elf2dmp: fix code style
  contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry
  contrib/elf2dmp: add PE name check and Windows Server 2022 support

 contrib/elf2dmp/addrspace.c |   1 +
 contrib/elf2dmp/main.c      | 108 ++++++++++++++++++++++-----------
 contrib/elf2dmp/pe.h        | 115 ++++++++++++++++++++----------------
 3 files changed, 140 insertions(+), 84 deletions(-)

Comments

Annie Li March 6, 2023, 9:35 p.m. UTC | #1

Hello Viktor,

This patch set looks good to me, thank you!

On 2/22/2023 4:12 PM, Viktor Prutyanov wrote:
> Hi,
>
> For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
> Windows Server 2022 guest. This patch series fixes it.
>
> v1: improve code-style fix
> v2: don't remove data directory entry RVA print and DOS header size check
Reviewed-by: Annie Li <[e-mail]>

Thanks

Annie

>
> Viktor Prutyanov (3):
>    contrib/elf2dmp: fix code style
>    contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry
>    contrib/elf2dmp: add PE name check and Windows Server 2022 support
>
>   contrib/elf2dmp/addrspace.c |   1 +
>   contrib/elf2dmp/main.c      | 108 ++++++++++++++++++++++-----------
>   contrib/elf2dmp/pe.h        | 115 ++++++++++++++++++++----------------
>   3 files changed, 140 insertions(+), 84 deletions(-)
>

Viktor Prutyanov March 16, 2023, 4:48 p.m. UTC | #2

> Hi,
> 
> For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
> Windows Server 2022 guest. This patch series fixes it.
> 
> v1: improve code-style fix
> v2: don't remove data directory entry RVA print and DOS header size check
> 
> Viktor Prutyanov (3):
> contrib/elf2dmp: fix code style
> contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry
> contrib/elf2dmp: add PE name check and Windows Server 2022 support
> 
> contrib/elf2dmp/addrspace.c | 1 +
> contrib/elf2dmp/main.c | 108 ++++++++++++++++++++++-----------
> contrib/elf2dmp/pe.h | 115 ++++++++++++++++++++----------------
> 3 files changed, 140 insertions(+), 84 deletions(-)
> 
> --
> 2.35.1

Hi Peter,

As we discussed, I would like to ask you to pick up this series.

Thanks,
Viktor Prutyanov

Peter Maydell March 17, 2023, 1:45 p.m. UTC | #3

On Thu, 16 Mar 2023 at 16:48, Viktor Prutyanov
<[e-mail]> wrote:
>
>
>
> > Hi,
> >
> > For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
> > Windows Server 2022 guest. This patch series fixes it.
> >
> > v1: improve code-style fix
> > v2: don't remove data directory entry RVA print and DOS header size check
> >
> > Viktor Prutyanov (3):
> > contrib/elf2dmp: fix code style
> > contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry
> > contrib/elf2dmp: add PE name check and Windows Server 2022 support
> >
> > contrib/elf2dmp/addrspace.c | 1 +
> > contrib/elf2dmp/main.c | 108 ++++++++++++++++++++++-----------
> > contrib/elf2dmp/pe.h | 115 ++++++++++++++++++++----------------
> > 3 files changed, 140 insertions(+), 84 deletions(-)
> >
> > --
> > 2.35.1
>
> Hi Peter,
>
> As we discussed, I would like to ask you to pick up this series.

Sure, I can put this into the target-arm pullreq I'm doing,
unless anybody prefers them to go into the tree via a
different route.

thanks
-- PMM

Viktor Prutyanov March 17, 2023, 3:21 p.m. UTC | #4

Thank you! Personally, I agree with any way to get the elf2dmp patch series into the tree.
 
Best regards,
Viktor Prutyanov