From patchwork Thu Mar 23 19:53:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 13186040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C8E6C6FD1C for ; Thu, 23 Mar 2023 19:54:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfR0s-0003CS-Cg; Thu, 23 Mar 2023 15:54:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfR0q-0003CJ-PU for qemu-devel@nongnu.org; Thu, 23 Mar 2023 15:54:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfR0o-0007PT-PW for qemu-devel@nongnu.org; Thu, 23 Mar 2023 15:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679601253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L3qoEbTSvNoTmsKY8awcradxbS1fexqfAkCV6o+r+1g=; b=forXwp4gaP0onz3bE2sV5fmeC3sCJOBWWedOsjd+mFTI6NMTzFbBCnmrT9wzoDMmmtjHli VqcoWNsmDygdjoJlczZwDloGyau16WpyUEEy+gOWOZPD/KRY1ClG3K0Xh4EjPn8qOY8XH0 BeJt+6HQp7uyrghErbTbPuCOiSSrpFQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-Qej5ZdpbMZWYFMGb35vsRg-1; Thu, 23 Mar 2023 15:54:10 -0400 X-MC-Unique: Qej5ZdpbMZWYFMGb35vsRg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 382128030A0; Thu, 23 Mar 2023 19:54:09 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27315440BC; Thu, 23 Mar 2023 19:54:06 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Liuxiangdong , Gautam Dawar , Jason Wang , alvaro.karsz@solid-run.com, "Gonglei (Arei)" , Lei Yang , si-wei.liu@oracle.com, Eli Cohen , Shannon Nelson , Laurent Vivier , "Michael S. Tsirkin" , Stefano Garzarella , Parav Pandit , Zhu Lingshan , Cindy Lu , longpeng2@huawei.com, Harpreet Singh Anand Subject: [PATCH for 8.1 v2 0/6] Move ASID test to vhost-vdpa net initialization Date: Thu, 23 Mar 2023 20:53:58 +0100 Message-Id: <20230323195404.1247326-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org QEMU v8.0.0-rc0 is able to switch dynamically between vhost-vdpa passthrough and SVQ mode as long as the net device does not have CVQ. The net device state followed (and migrated) by CVQ requires special care. A pre-requisite to add CVQ to that framework is to determine if devices with CVQ are migratable or not at initialization time. The solution to it is to always shadow only CVQ, and vq groups and ASID are used for that. However, current qemu version only checks ASID at device start (as "driver set DRIVER_OK status bit"), not at device initialization. A check at initialization time is required. Otherwise, the guest would be able to set and remove migration blockers at will [1]. This series is a requisite for migration of vhost-vdpa net devices with CVQ. However it already makes sense by its own, as it reduces the number of ioctls at migration time, decreasing the error paths there. [1] https://lore.kernel.org/qemu-devel/2616f0cd-f9e8-d183-ea78-db1be4825d9c@redhat.com/ --- v2: * Take out the reset of the device from vhost_vdpa_cvq_is_isolated (reported by Lei Yang). * Expand patch messages by Stefano G. questions. Eugenio Pérez (6): vdpa: Remove status in reset tracing vdpa: add vhost_vdpa_reset_status_fd vdpa: add vhost_vdpa_set_dev_features_fd vdpa: return errno in vhost_vdpa_get_vring_group error vdpa: move CVQ isolation check to net_init_vhost_vdpa vdpa: Cache cvq group in VhostVDPAState include/hw/virtio/vhost-vdpa.h | 2 + hw/virtio/vhost-vdpa.c | 78 ++++++++----- net/vhost-vdpa.c | 199 +++++++++++++++++++++++++++------ hw/virtio/trace-events | 2 +- 4 files changed, 221 insertions(+), 60 deletions(-)