| Message ID | 20230327144553.4315-1-faithilikerun@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add zoned storage emulation to virtio-blk driver | expand |
On Mon, Mar 27, 2023 at 10:45:48PM +0800, Sam Li wrote: > This patch adds zoned storage emulation to the virtio-blk driver. It > implements the virtio-blk ZBD support standardization that is > recently accepted by virtio-spec. The link to related commit is at > > https://github.com/oasis-tcs/virtio-spec/commit/b4e8efa0fa6c8d844328090ad15db65af8d7d981 > > The Linux zoned device code that implemented by Dmitry Fomichev has been > released at the latest Linux version v6.3-rc1. > > Aside: adding zoned=on alike options to virtio-blk device will be > considered in following-up plan. > > Note: Sorry to send it again because of the previous incoherent patches caused > by network error. virtio bits look ok. Reviewed-by: Michael S. Tsirkin <mst@redhat.com> merge through block layer tree I'm guessing? > v9: > - address review comments > * add docs for zoned emulation use case [Matias] > * add the zoned feature bit to qmp monitor [Matias] > * add the version number for newly added configs of accounting [Markus] > > v8: > - address Stefan's review comments > * rm aio_context_acquire/release in handle_req > * rename function return type > * rename BLOCK_ACCT_APPEND to BLOCK_ACCT_ZONE_APPEND for clarity > > v7: > - update headers to v6.3-rc1 > > v6: > - address Stefan's review comments > * add accounting for zone append operation > * fix in_iov usage in handle_request, error handling and typos > > v5: > - address Stefan's review comments > * restore the way writing zone append result to buffer > * fix error checking case and other errands > > v4: > - change the way writing zone append request result to buffer > - change zone state, zone type value of virtio_blk_zone_descriptor > - add trace events for new zone APIs > > v3: > - use qemuio_from_buffer to write status bit [Stefan] > - avoid using req->elem directly [Stefan] > - fix error checkings and memory leak [Stefan] > > v2: > - change units of emulated zone op coresponding to block layer APIs > - modify error checking cases [Stefan, Damien] > > v1: > - add zoned storage emulation > > Sam Li (5): > include: update virtio_blk headers to v6.3-rc1 > virtio-blk: add zoned storage emulation for zoned devices > block: add accounting for zone append operation > virtio-blk: add some trace events for zoned emulation > docs/zoned-storage:add zoned emulation use case > > block/qapi-sysemu.c | 11 + > block/qapi.c | 18 + > docs/devel/zoned-storage.rst | 17 + > hw/block/trace-events | 7 + > hw/block/virtio-blk-common.c | 2 + > hw/block/virtio-blk.c | 405 +++++++++++++++++++ > hw/virtio/virtio-qmp.c | 2 + > include/block/accounting.h | 1 + > include/standard-headers/drm/drm_fourcc.h | 12 + > include/standard-headers/linux/ethtool.h | 48 ++- > include/standard-headers/linux/fuse.h | 45 ++- > include/standard-headers/linux/pci_regs.h | 1 + > include/standard-headers/linux/vhost_types.h | 2 + > include/standard-headers/linux/virtio_blk.h | 105 +++++ > linux-headers/asm-arm64/kvm.h | 1 + > linux-headers/asm-x86/kvm.h | 34 +- > linux-headers/linux/kvm.h | 9 + > linux-headers/linux/vfio.h | 15 +- > linux-headers/linux/vhost.h | 8 + > qapi/block-core.json | 68 +++- > qapi/block.json | 4 + > 21 files changed, 794 insertions(+), 21 deletions(-) > > -- > 2.39.2
On Wed, 29 Mar 2023 at 01:01, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Mon, Mar 27, 2023 at 10:45:48PM +0800, Sam Li wrote: > > This patch adds zoned storage emulation to the virtio-blk driver. It > > implements the virtio-blk ZBD support standardization that is > > recently accepted by virtio-spec. The link to related commit is at > > > > https://github.com/oasis-tcs/virtio-spec/commit/b4e8efa0fa6c8d844328090ad15db65af8d7d981 > > > > The Linux zoned device code that implemented by Dmitry Fomichev has been > > released at the latest Linux version v6.3-rc1. > > > > Aside: adding zoned=on alike options to virtio-blk device will be > > considered in following-up plan. > > > > Note: Sorry to send it again because of the previous incoherent patches caused > > by network error. > > virtio bits look ok. > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > merge through block layer tree I'm guessing? Sounds good. Thank you! Stefan
Stefan Hajnoczi <stefanha@gmail.com> 于2023年4月3日周一 20:18写道： > > On Wed, 29 Mar 2023 at 01:01, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Mon, Mar 27, 2023 at 10:45:48PM +0800, Sam Li wrote: > > > > virtio bits look ok. > > > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > > > merge through block layer tree I'm guessing? > > Sounds good. Thank you! Hi Stefan, I've sent the v8 zone append write to the list where I move the wps field to BlockDriverState. It will make a small change the emulation code, which is in hw/block/virtio-blk.c of [2/5] virtio-blk: add zoned storage emulation for zoned devices: - if (BDRV_ZT_IS_CONV(bs->bl.wps->wp[index])) { + if (BDRV_ZT_IS_CONV(bs->wps->wp[index])) { Please let me know if you prefer a new version or not. Thanks, Sam
On Tue, Apr 04, 2023 at 11:46:13PM +0800, Sam Li wrote: > Stefan Hajnoczi <stefanha@gmail.com> 于2023年4月3日周一 20:18写道： > > > > On Wed, 29 Mar 2023 at 01:01, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Mon, Mar 27, 2023 at 10:45:48PM +0800, Sam Li wrote: > > > > > > virtio bits look ok. > > > > > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > merge through block layer tree I'm guessing? > > > > Sounds good. Thank you! > > Hi Stefan, > > I've sent the v8 zone append write to the list where I move the wps > field to BlockDriverState. It will make a small change the emulation > code, which is in hw/block/virtio-blk.c of [2/5] virtio-blk: add zoned > storage emulation for zoned devices: > - if (BDRV_ZT_IS_CONV(bs->bl.wps->wp[index])) { > + if (BDRV_ZT_IS_CONV(bs->wps->wp[index])) { > > Please let me know if you prefer a new version or not. Yes, please. Stefan