[v4,0/1] hw/riscv: Add ACT related support

Message

Weiwei Li April 5, 2023, 9:57 a.m. UTC

ACT tests play an important role in riscv tests. This patch tries to
add related support to run ACT tests.

The port is available here:
https://github.com/plctlab/plct-qemu/tree/plct-act-upstream-v2

The ACT tests can be run on qemu-system-riscv32/64 with machine argument
"-M spike,signature=<FILE>,signature-granularity=<granurity>".

v4:
* update error message for opening signature file failed
* add check for existence of begin/end_signature symbols when trying to update signature file.

v3:
* move definition of signature related parameters from spike.c to riscv_htif.c

v2：
* move "extern ..." declaration from riscv_htif.c to riscv_htif.h

Weiwei Li (1):
  hw/riscv: Add signature dump function for spike to run ACT tests

 hw/char/riscv_htif.c         | 44 +++++++++++++++++++++++++++++++++++-
 hw/riscv/spike.c             | 13 +++++++++++
 include/hw/char/riscv_htif.h |  3 +++
 3 files changed, 59 insertions(+), 1 deletion(-)

Comments

Alistair Francis April 6, 2023, 1:31 a.m. UTC | #1

On Wed, Apr 5, 2023 at 7:58 PM Weiwei Li <[e-mail]> wrote:
>
> ACT tests play an important role in riscv tests. This patch tries to
> add related support to run ACT tests.
>
> The port is available here:
> https://github.com/plctlab/plct-qemu/tree/plct-act-upstream-v2
>
> The ACT tests can be run on qemu-system-riscv32/64 with machine argument
> "-M spike,signature=<FILE>,signature-granularity=<granurity>".
>
> v4:
> * update error message for opening signature file failed
> * add check for existence of begin/end_signature symbols when trying to update signature file.
>
> v3:
> * move definition of signature related parameters from spike.c to riscv_htif.c
>
> v2：
> * move "extern ..." declaration from riscv_htif.c to riscv_htif.h
>
> Weiwei Li (1):
>   hw/riscv: Add signature dump function for spike to run ACT tests

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  hw/char/riscv_htif.c         | 44 +++++++++++++++++++++++++++++++++++-
>  hw/riscv/spike.c             | 13 +++++++++++
>  include/hw/char/riscv_htif.h |  3 +++
>  3 files changed, 59 insertions(+), 1 deletion(-)
>
> --
> 2.25.1
>
>