From patchwork Mon Apr 10 18:20:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Warner Losh X-Patchwork-Id: 13206575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 458CAC77B71 for ; Mon, 10 Apr 2023 18:21:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plw8f-0002eD-OW; Mon, 10 Apr 2023 14:21:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plw8c-0002bq-OH for qemu-devel@nongnu.org; Mon, 10 Apr 2023 14:21:10 -0400 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plw8a-0000ec-D7 for qemu-devel@nongnu.org; Mon, 10 Apr 2023 14:21:10 -0400 Received: by mail-il1-x134.google.com with SMTP id s4so2662966ilv.11 for ; Mon, 10 Apr 2023 11:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1681150865; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hc1Fiq7lpQJllIA5RpRAXFMfgI7s9IAeyjPAAa+Q3UI=; b=PCjZY/eKBFTtmBe5E4QoFO3bJm9mZwiGL8fRvA4qraTfp7pCzlqP+1cSL2Zmu5ss3K 9FACQcexHU+2dlw3sESyqCXB5qub9TI/LGeList+uaeLgjYxqAXpCJkCaKHH1CG02uEW CFs+FVozjOSpSUCei60+NRpUiaquQYLNKcyQs4OGMDlwcLhQvpxTQKx2KrS4mA0tYDRK neRH2ORh2OmR30lVRD2LMKiGjYW4+8gsO419PsuVFCh8nIuE47v2cZnrhFFq1LlMJA/1 e0SCoRcBjRrVC3etgiQAxn1x57e+bQ6H4joQCqtJlLeHRswxFeO3UXG6zJGSBSNNyDTv zQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681150865; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hc1Fiq7lpQJllIA5RpRAXFMfgI7s9IAeyjPAAa+Q3UI=; b=k2SXagFR0Mi3I77bvW2tuVzkpoojVt4mVKxXBJ+rTl3qW2weIhAsePX9OimVXPOpoA wmGA1skeUXXJy+/c32lKN/Kso6Zw3ih8/smJ2o6AHoi/lIfzs4MvGbE6/J8WR3OTng5C CquGvswkdha5swuHYOD8oz2HjrE/+DfttAwehv9FLeOP2hcP5puyNIa9vrLBnbrxEA9K Q/gdH7qF+dK8tu6o5ZDlpM8wL1rrx6TrRzrns9nkAHfZ0VvhxPKmKTMTfxKiuEVoSoso KFMd6xURYntOLdyvQqmgpZ7pcTrg8iyv6+JtehzMrHcseIkB4Sa0LNxH7NSCC0hsB0gX Z/zw== X-Gm-Message-State: AAQBX9fc+a5dQ67eIpdskA3X4tMbDn6W1EYTylicmFYwoDwdf9IPHdht p19tdHDJkmLnivM8W+jFBWnn8zGiR8JGhWnENHI= X-Google-Smtp-Source: AKy350Z/PoUFCm+XkWFa4chWCqXaPxXeXY8bctDzdZOinZNx9V6JS/dcSE+fB9AcdnQRw2no3qO+Cw== X-Received: by 2002:a92:60c:0:b0:326:1f4a:276c with SMTP id x12-20020a92060c000000b003261f4a276cmr7349003ilg.21.1681150865438; Mon, 10 Apr 2023 11:21:05 -0700 (PDT) Received: from dune.bsdimp.com (c-71-237-47-177.hsd1.co.comcast.net. [71.237.47.177]) by smtp.gmail.com with ESMTPSA id a15-20020a056e02120f00b00313b281ecd2sm3104314ilq.70.2023.04.10.11.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 11:21:05 -0700 (PDT) From: Warner Losh To: qemu-devel@nongnu.org Cc: jrtc27@jrtc27.com, riastradh@netbsd.org, Kyle Evans , Ryo ONODERA , Brad Smith , Warner Losh , reinoud@netbsd.org Subject: [PATCH v2 00/19] bsd-user 2023 Q2 first batch Date: Mon, 10 Apr 2023 12:20:37 -0600 Message-Id: <20230410182056.320-1-imp@bsdimp.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Received-SPF: none client-ip=2607:f8b0:4864:20::134; envelope-from=imp@bsdimp.com; helo=mail-il1-x134.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This series is a number of misc cleanups. First, this replaces my plans to remove netbsd and openbsd code entirely. I've been in contact with the NetBSD folks that would like to make things work. The plan is that I'll not remove it in qemu-project, and restore them in bsd-user fork. These changes clean up some of the mess that's here: I've moved the bits that make sense here, and removed the ones that don't (but upstream I've moved them when it makes sense). My intention is to work with the NetBSD folks (and OpenBSD too if they want) to cope with the structural issues I'm aware of in bsd-user fork. Future contributions should go via that route at a rate of contributions (I have little time to do the work, but will commit to finding time to do the coordination and review work). Next I've #ifdef'd some mmap handling based on certain flags being defined or not. This was something I'd removed before, and were in what Taylor sent me, so I've restored the relevant ones. The rest of the patch that Taylor sent me conflicts with bsd-user and needs some work to get it in upstream. I removed a few unused mmap defines as well. And I cleanup mmap.c to remove gratuitous differences and pass checkpatch.pl. Next, I've made unimplmeneted system calls generate SIGSYS. For the moment, this is the best we should do since so much is unimplemented and as things get implemented this will allow controlled testing of code to ensure it doesn't silently succeed, giving the impression things are working when they aren't. I also add SIGSYS to the uncaught coredump signal list, to match FreeBSD's behavior. I only do this on arm, though, because the signal implementation on x86 is incomplete (even upstream) and I didn't want to take chances. Finally, I've included the core dump code. There's about 600 lines of sysctl support that I've included as separate commits of ~150 lines each (and incidentlaly, added the translation to os-sys.c for those bits). The core dump code itself is largely copied from linux-user/elfload.c by sson (so he gets the author credit). I moved it to elfcore.c when I was upstremaing in the past and upstreamed a stub. One of the patches in this series replaces elfcore.c and is 1300 lines long. It's not easily sliced up into smaller bits that compile, but I'm open to suggestions. It's known to "work" in the sense that it will generate core files that gdb can read and intelligently parse. This patch series is for after 8.0 is done, but before any GSoC projects start, and will be independent of any GSoC contribution tasks. v2: A few more 'high line count, easy to review' changes: - Remove a few more files - Regenerate FreeBSD system calls - Remove host-os.h, since we no longer plan to support multiple BSDs in one binary. - Review comments: Remove USE_ELF_CORE_DUMP and change ifdefs for MAP_ Need reviews for parts 2, 17, 18, 19 for sure. Parts 3 and 14 just have Acked-by. Stacey Son (6): bsd-user: h2g_rusage bsd-user: Implement do_sysctl_kern_getprocs bsd-user: Implement do_sysctl_kern_proc_filedesc bsd-user: Implement do_sysctl_kern_proc_vmmap bsd-user: Implement sysctl kern.proc, except kern.proc.full_path bsd-user: Implement core dumps Warner Losh (13): bsd-user: Make print_* public bsd-user: Ifdef a few MAP_ constants for NetBSD / OpenBSD. bsd-user: Cleanup style. bsd-user: Move system FreeBSD call table to freebsd/os-syscall.c bsd-user: Remove NetBSD specific syscall printing bsd-user: Remove OpenBSD specific syscall printing bsd-user: Move system call include to os-syscall.h bsd-user: Remove useless mmap definitions bsd-user: Add SIGSYS to core dump signals. bsd-user: Implement SIGSYS on arm bsd-user: Remove host-os.h bsd-user: Update system call list bsd-user: Eliminate USE_ELF_CORE_DUMP bsd-user/arm/target_arch_cpu.h | 8 + bsd-user/arm/target_arch_elf.h | 1 - bsd-user/bsd-proc.c | 48 + bsd-user/elfcore.c | 1315 +++++++++++++++++++- bsd-user/elfload.c | 5 - bsd-user/freebsd/os-sys.c | 508 +++++++- bsd-user/freebsd/os-syscall.c | 19 + bsd-user/freebsd/os-syscall.h | 23 + bsd-user/freebsd/syscall_nr.h | 1035 +++++++-------- bsd-user/i386/target_arch_elf.h | 1 - bsd-user/main.c | 1 - bsd-user/meson.build | 1 + bsd-user/mmap.c | 105 +- bsd-user/netbsd/host-os.h | 25 - bsd-user/netbsd/os-syscall.h | 16 + bsd-user/openbsd/host-os.h | 25 - bsd-user/openbsd/os-syscall.h | 16 + bsd-user/{freebsd/host-os.h => qemu-bsd.h} | 15 +- bsd-user/qemu.h | 44 +- bsd-user/signal.c | 13 +- bsd-user/strace.c | 88 +- bsd-user/syscall_defs.h | 69 +- bsd-user/x86_64/target_arch_elf.h | 1 - 23 files changed, 2616 insertions(+), 766 deletions(-) create mode 100644 bsd-user/bsd-proc.c create mode 100644 bsd-user/freebsd/os-syscall.h delete mode 100644 bsd-user/netbsd/host-os.h create mode 100644 bsd-user/netbsd/os-syscall.h delete mode 100644 bsd-user/openbsd/host-os.h create mode 100644 bsd-user/openbsd/os-syscall.h rename bsd-user/{freebsd/host-os.h => qemu-bsd.h} (72%)