[v4,0/8] migration: Modified 'migrate' and 'migrate-incoming' QAPI commands for migration

Message

Het Gala May 12, 2023, 2:32 p.m. UTC

This is v4 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.

Link to previous upstream community patchset links:
v1: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04339.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02106.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02473.html

Changelog:
----------
- Restructured the patchset into 8 different independently build patches.
- Patches [1-2] focused on introducing MigrateAddress struct to QAPIs
- Patches [3-5] focused on implementing modified QAPI design to transport
  backends like (socket, exec and rdma).
- Patches [6-8] focused on introducing MigrateChannelList struct on top of
  MigrateAddress QAPI as an additional argument to both migration QAPIs
  and also implemented in the migration code path.

v4 series look a longer time to post, as it was blocked because of improvment
change required on the qapi design level to allow 'unions inside another
union'.
For detailed discussion on this, please follow the upstream discussion here:
https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg06782.html
https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg06783.html

I would like to thank Markus and Daniel for merging patches to allow union
inside another union and also would like to thank Eric for his reviews
on the patches.

Het Gala (8):
  migration: introduced 'MigrateAddress' in QAPI for migration wire
    protocol.
  migration: Converts uri parameter into 'MigrateAddress' struct
  migration: converts socket backend to accept MigrateAddress struct
  migration: converts rdma backend to accept MigrateAddress struct
  migration: converts exec backend to accept MigrateAddress struct.
  migration: modified 'migrate' QAPI to accept 'channels' argument for
    migration
  migration: modified 'migrate-incoming' QAPI to accept 'channels'
    argument for migration.
  migration: Introduced MigrateChannelList struct to migration code
    flow.

 migration/exec.c               |  60 +++++++---
 migration/exec.h               |   8 +-
 migration/migration-hmp-cmds.c | 127 ++++++++++++++++++++-
 migration/migration.c          | 196 +++++++++++++++++++++++++++------
 migration/rdma.c               |  38 +++----
 migration/rdma.h               |   6 +-
 migration/socket.c             |  39 ++-----
 migration/socket.h             |   7 +-
 qapi/migration.json            | 145 +++++++++++++++++++++++-
 softmmu/vl.c                   |   2 +-
 10 files changed, 512 insertions(+), 116 deletions(-)

Comments

Markus Armbruster May 16, 2023, 10:32 a.m. UTC | #1

Doesn't apply to current master anymore, and patchew couldn't apply it,
either[*].  I'll look at v5.  Thanks!


[*] https://patchew.org/QEMU/[e-mail]/