mbox series

[v3,0/5] Optimize UNMAP call and bug fix

Message ID 20230608095231.225450-1-zhenzhong.duan@intel.com (mailing list archive)
Headers show
Series Optimize UNMAP call and bug fix | expand

Message

Duan, Zhenzhong June 8, 2023, 9:52 a.m. UTC 
Hi All,

This patchset includes some fixes on VFIO dirty sync and vIOMMU.
PATCH1 isn't needed now as dependent changes in PATCH2 is removed,
but as Peter has given Reviewed-by, leave it to maintainer to
decide if pick or not.

Tested net card passthrough, ping/ssh pass
Tested DSA vdev passthrough, start dmatest then do live migration, pass.
Checked the LM performance before and after patch, no explicit difference.
(DSA vdev requires customed kernel and qemu)

v3:
updated PATCH2 to fix VFIO dirty sync in Peter suggested way.
split PATCH4 in v2 to PATCH4 and PATCH5 as they target different issue.
dropped PATCH3 in v2.
add Suggested-by.

Thanks

Zhenzhong Duan (5):
  util: Add iova_tree_foreach_range_data
  intel_iommu: Fix a potential issue in VFIO dirty page sync
  intel_iommu: Fix flag check in replay
  intel_iommu: Fix address space unmap
  intel_iommu: Optimize out some unnecessary UNMAP calls

 hw/i386/intel_iommu.c    | 37 +++++++++++++++++++------------------
 include/qemu/iova-tree.h | 17 +++++++++++++++--
 util/iova-tree.c         | 31 +++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+), 20 deletions(-)

Comments

Peter Xu June 8, 2023, 3:53 p.m. UTC | #1 
On Thu, Jun 08, 2023 at 05:52:26PM +0800, Zhenzhong Duan wrote:
> Hi All,
> 
> This patchset includes some fixes on VFIO dirty sync and vIOMMU.
> PATCH1 isn't needed now as dependent changes in PATCH2 is removed,
> but as Peter has given Reviewed-by, leave it to maintainer to
> decide if pick or not.

Let's drop patch 1 until it's really used.  Thanks,
Duan, Zhenzhong June 9, 2023, 3:32 a.m. UTC | #2 
>-----Original Message-----
>From: Peter Xu <peterx@redhat.com>
>Sent: Thursday, June 8, 2023 11:54 PM
>To: Duan, Zhenzhong <zhenzhong.duan@intel.com>
>Cc: qemu-devel@nongnu.org; mst@redhat.com; jasowang@redhat.com;
>pbonzini@redhat.com; richard.henderson@linaro.org; eduardo@habkost.net;
>marcel.apfelbaum@gmail.com; alex.williamson@redhat.com;
>clg@redhat.com; david@redhat.com; philmd@linaro.org;
>kwankhede@nvidia.com; cjia@nvidia.com; Liu, Yi L <yi.l.liu@intel.com>; Peng,
>Chao P <chao.p.peng@intel.com>
>Subject: Re: [PATCH v3 0/5] Optimize UNMAP call and bug fix
>
>On Thu, Jun 08, 2023 at 05:52:26PM +0800, Zhenzhong Duan wrote:
>> Hi All,
>>
>> This patchset includes some fixes on VFIO dirty sync and vIOMMU.
>> PATCH1 isn't needed now as dependent changes in PATCH2 is removed, but
>> as Peter has given Reviewed-by, leave it to maintainer to decide if
>> pick or not.
>
>Let's drop patch 1 until it's really used.  Thanks,

Will drop it in next version.

Thanks
Zhenzhong