mbox series

[0/3] target/m68k: Fix a few semihosting bugs

Message ID 20230802161914.395443-1-keithp@keithp.com (mailing list archive)
Headers show
Series target/m68k: Fix a few semihosting bugs | expand

Message

Keith Packard Aug. 2, 2023, 4:19 p.m. UTC
The first two patches mirror similar patches I recently sent for nios2.

 1. Use correct parameter for EXIT (d1 instead of d0)
 2. Fix use of deposit64 in LSEEK (argument order was incorrect)

The second patch has also been submitted by Peter Maydell, it's
included here because it was required to get things working.

The final patch adds semihosting support for non-ColdFire processors
(which don't support the HALT instruction) by using BKPT #0 instead
(as per the m68k semihosting docs).

All of these have been tested using picolibc (patches for m68k support
there are moving upstream as well).

Comments

Peter Maydell Aug. 3, 2023, 10:06 a.m. UTC | #1
On Wed, 2 Aug 2023 at 17:20, Keith Packard via <qemu-devel@nongnu.org> wrote:
>
> The first two patches mirror similar patches I recently sent for nios2.
>
>  1. Use correct parameter for EXIT (d1 instead of d0)
>  2. Fix use of deposit64 in LSEEK (argument order was incorrect)
>
> The second patch has also been submitted by Peter Maydell, it's
> included here because it was required to get things working.

The usual way we do that is that you include my patch in your
series, and add your signed-off-by line (indicating it has
come via you).

thanks
-- PMM
Richard Henderson Oct. 3, 2023, 10:39 p.m. UTC | #2
On 8/2/23 09:19, Keith Packard via wrote:
> The first two patches mirror similar patches I recently sent for nios2.
> 
>   1. Use correct parameter for EXIT (d1 instead of d0)
>   2. Fix use of deposit64 in LSEEK (argument order was incorrect)
> 
> The second patch has also been submitted by Peter Maydell, it's
> included here because it was required to get things working.
> 
> The final patch adds semihosting support for non-ColdFire processors
> (which don't support the HALT instruction) by using BKPT #0 instead
> (as per the m68k semihosting docs).
> 
> All of these have been tested using picolibc (patches for m68k support
> there are moving upstream as well).


Queued patch 1 to m68k-next.  Patch 2 has already been committed, and I've just sent a 
replacement for patch 3.


r~


PS: I hadn't noticed the picolibc note here at the time; I'll give that a try later today.