From patchwork Mon Aug 7 19:07:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13344756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49019C001DE for ; Mon, 7 Aug 2023 19:08:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qT5Zz-0003hy-D5; Mon, 07 Aug 2023 15:07:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT5Zx-0003hc-DN for qemu-devel@nongnu.org; Mon, 07 Aug 2023 15:07:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT5Zv-0005lv-RU for qemu-devel@nongnu.org; Mon, 07 Aug 2023 15:07:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691435262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQUkGOkw0a7RTsG8Adl5Vcf3uPH0r/lnSYN2Bdt6Lwg=; b=Q3BZpsn4aJhUUa3zTYeri7Rq8FPkcMDIaRI3L+52nJJw+5tgI9WHb3H4wX/QP44p/2ma6L 9aqFSF4X7mKepsl0dllUIBQRJKAKhYxer3n95ySXWVDru3QphDw/yPTeGt6tm/mTklrAqt yOhbcFbZD2Q9nrMEU2Z1VbXPGgY42eo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-yk3SVu85Nb62pJC2v0bSLA-1; Mon, 07 Aug 2023 15:07:39 -0400 X-MC-Unique: yk3SVu85Nb62pJC2v0bSLA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F26680CC40; Mon, 7 Aug 2023 19:07:39 +0000 (UTC) Received: from t14s.redhat.com (unknown [10.39.192.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95239403166; Mon, 7 Aug 2023 19:07:37 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Cc: David Hildenbrand , Paolo Bonzini , Peter Xu , Igor Mammedov , Thiner Logoer , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH v1 0/3] softmmu/physmem: file_ram_open() readonly improvements Date: Mon, 7 Aug 2023 21:07:31 +0200 Message-ID: <20230807190736.572665-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Patch #1 is the result of the discussion of: "[PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open" [1] Instead of handling it inside file_ram_open(), handle it in the caller and only fallback to readonly in a MAP_PRIVATE mapping. Patch #2 refuses to create readonly files instead of creating a new file and opening it writable. Patch #3 no longer returns directories from file_ram_open(), resulting in a better error message when trying to open a readonly file but specifying a directory. [1] https://lkml.kernel.org/r/20230726145912.88545-1-logoerthiner1@163.com Cc: Paolo Bonzini Cc: Peter Xu Cc: Igor Mammedov Cc: Thiner Logoer Cc: "Philippe Mathieu-Daudé" David Hildenbrand (2): softmmu/physmem: fail creation of new files in file_ram_open() with readonly=true softmmu/physmem: never return directories from file_ram_open() Thiner Logoer (1): softmmu/physmem: fallback to opening guest RAM file as readonly in a MAP_PRIVATE mapping softmmu/physmem.c | 52 +++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 44 insertions(+), 8 deletions(-) Tested-by: Thiner Logoer