From patchwork Wed Sep 13 14:49:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 13383252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66B23EDEC6A for ; Wed, 13 Sep 2023 14:50:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgRBz-0000yH-1u; Wed, 13 Sep 2023 10:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgRBw-0000xk-5f for qemu-devel@nongnu.org; Wed, 13 Sep 2023 10:50:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgRBt-0000JG-Da for qemu-devel@nongnu.org; Wed, 13 Sep 2023 10:50:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694616604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kLuxwXMabIXjZuF6ObvAibxilK9PiG1oLtLYD4imoaE=; b=WbLo5iIe3UXqPk1kalMULpET0I7EfHd0NKrN/2pmQpkuCU3IrVPwNcsGceRRriR7cEruCg Dp40kAZTNGgpdZVGtWguzXz4vh3xTPLw7tUeZ24VmSicqdBvn4+dw9ASIUiw7WEkxVsIvC 29ykx3S2jepN+/c52qRf7fgcj+bm6Bo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-QZakFFfhN8GB7zJoVATghw-1; Wed, 13 Sep 2023 10:50:02 -0400 X-MC-Unique: QZakFFfhN8GB7zJoVATghw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 01CA8101FAA4 for ; Wed, 13 Sep 2023 14:50:02 +0000 (UTC) Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.194.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19E8363A52; Wed, 13 Sep 2023 14:50:00 +0000 (UTC) From: Laszlo Ersek To: lersek@redhat.com, qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Gerd Hoffmann Subject: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic Date: Wed, 13 Sep 2023 16:49:55 +0200 Message-Id: <20230913144959.41891-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=lersek@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Fix a recent regression (crash) in the multihead check; clean up the code some more. Cc: "Marc-André Lureau" (odd fixer:Graphics) Cc: Gerd Hoffmann (odd fixer:Graphics) Thanks, Laszlo Laszlo Ersek (4): ui/console: make qemu_console_is_multihead() static ui/console: only walk QemuGraphicConsoles in qemu_console_is_multihead() ui/console: eliminate QOM properties from qemu_console_is_multihead() ui/console: sanitize search in qemu_graphic_console_is_multihead() include/ui/console.h | 1 - ui/console.c | 24 +++++++++----------- 2 files changed, 11 insertions(+), 14 deletions(-) Reviewed-by: Marc-André Lureau