From patchwork Wed Oct 11 20:55:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 13417958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 340A5CDB47E for ; Wed, 11 Oct 2023 20:57:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqgFa-0003x9-5V; Wed, 11 Oct 2023 16:56:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqgFU-0003uk-3m for qemu-devel@nongnu.org; Wed, 11 Oct 2023 16:56:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqgFG-0007cF-5V for qemu-devel@nongnu.org; Wed, 11 Oct 2023 16:56:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697057752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7984WkHZrDN2JarvynBZGjt/Lw/wAHWkpIXxO0hGd4w=; b=ix+mfeg1jHGnYwj6hZuIbumlDn8EJYNff2kfK2aJLGDW4PlujqiQvgUd5xKUr0iewTgGYS 0zMueCTDEtVGZZPi0WYefHgTc+xG4HUnHGsWrvRfeA+iXB80obnbYchLDjkw1p9sMDyjXI x/Z7IxmuouCNXBgiNTaV+Y6vChaA41Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-GjAXgMGcOE-9WWlUpkItAg-1; Wed, 11 Oct 2023 16:55:50 -0400 X-MC-Unique: GjAXgMGcOE-9WWlUpkItAg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A8B7811E7B; Wed, 11 Oct 2023 20:55:50 +0000 (UTC) Received: from secure.mitica (unknown [10.39.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id A13A82026D4B; Wed, 11 Oct 2023 20:55:49 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Cc: Leonardo Bras , Peter Xu , Fabiano Rosas , Juan Quintela Subject: [PATCH 0/1] migration: Fix non-multifd migration Date: Wed, 11 Oct 2023 22:55:47 +0200 Message-ID: <20231011205548.10571-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Fix sending multifd sync packets when not multifd is seleceted. Basically we were using: if (migrate_multifd_flush_after_each_iteration()) { ...} and if (!migrate_multifd_flush_after_each_iteration()) { ...} But that is not enough for non multifd migration, so changed to also check first if migrate_multid() is enabled in each test. Please, review. Juan Quintela (1): migration: Non multifd migration don't care about multifd flushes migration/ram.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)