From patchwork Mon Oct 23 14:02:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13432881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD192CDB474 for ; Mon, 23 Oct 2023 14:03:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quvVs-00056r-7Z; Mon, 23 Oct 2023 10:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quvVj-00056G-BT for qemu-devel@nongnu.org; Mon, 23 Oct 2023 10:02:27 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quvVg-0003a9-A0 for qemu-devel@nongnu.org; Mon, 23 Oct 2023 10:02:27 -0400 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SDcLM3hZQz6K9DT; Mon, 23 Oct 2023 22:01:31 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 23 Oct 2023 15:02:10 +0100 To: , , Michael Tsirkin , Michael Tokarev CC: , Fan Ni , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= Subject: [PATCH v5 0/5] hw/cxl: Line length reduction and related Date: Mon, 23 Oct 2023 15:02:05 +0100 Message-ID: <20231023140210.3089-1-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron X-Patchwork-Original-From: Jonathan Cameron via From: Jonathan Cameron Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v5: - As _Static_assert() is a declaration it cannot follow a label (until C23). Upshot of that is to compile in clang (possibly older GCC) we need to add {} to case statements that start with QEMU_BUILD_BUG_ON() - Add patch to handle another QEMU_BUILD_BUG_ON() case by dropping the unnecessary check. Suggested-by: Michael S. Tsirkin Michael observed that the CXL code regularly went above the 80 character recommendation and in many cases this was not necessary for readability. This series is focused on tidying this up for the existing code so that we can maintain the preferred formatting going forwards. Jonathan Cameron (5): hw/cxl: Use a switch to explicitly check size in caps_reg_read() hw/cxl: Use switch statements for read and write of cachemem registers hw/cxl: CXLDVSECPortExtensions renamed to CXLDVSECPortExt hw/cxl: Line length reductions hw/cxl: Fix a QEMU_BUILD_BUG_ON() in switch statement scope issue. include/hw/cxl/cxl_component.h | 3 +- include/hw/cxl/cxl_device.h | 5 +- include/hw/cxl/cxl_events.h | 3 +- include/hw/cxl/cxl_pci.h | 6 +- hw/cxl/cxl-cdat.c | 3 +- hw/cxl/cxl-component-utils.c | 130 ++++++++++++++++++++------------- hw/cxl/cxl-device-utils.c | 11 ++- hw/cxl/cxl-events.c | 9 ++- hw/cxl/cxl-mailbox-utils.c | 21 ++++-- hw/mem/cxl_type3.c | 31 +++++--- hw/mem/cxl_type3_stubs.c | 5 +- hw/pci-bridge/cxl_downstream.c | 2 +- hw/pci-bridge/cxl_root_port.c | 2 +- hw/pci-bridge/cxl_upstream.c | 2 +- 14 files changed, 144 insertions(+), 89 deletions(-)