From patchwork Tue Oct 24 15:10:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 13434738 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6737AC07545 for ; Tue, 24 Oct 2023 15:11:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvJ3Z-0004qB-KV; Tue, 24 Oct 2023 11:10:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJ3V-0004pe-3T for qemu-devel@nongnu.org; Tue, 24 Oct 2023 11:10:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJ3S-0000n5-VS for qemu-devel@nongnu.org; Tue, 24 Oct 2023 11:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698160249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XTQNUBz5akEhhajRNOSIzEmG2tHp1u0469FC9RMFLvA=; b=PX2059k3t4nxK6ufhaLSramaLA65vyp160o+j9rVl7liqGggyLUiDX26UJR8jk4CoYebuW GddQ8FChbZbZoFzSJ9XNTiVqrJTPgENaJOi8ox9jK1jvI6pMkWPKp6fMKiUqGb9TxS2V6U josRIwMQacJe590dis7oE6uV94t/fAo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-T3O9pmIUOLqLyLuInej4YQ-1; Tue, 24 Oct 2023 11:10:46 -0400 X-MC-Unique: T3O9pmIUOLqLyLuInej4YQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9201A101A54C; Tue, 24 Oct 2023 15:10:45 +0000 (UTC) Received: from secure.mitica (unknown [10.39.194.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id 549DC2026D4C; Tue, 24 Oct 2023 15:10:43 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Cc: Fam Zheng , qemu-block@nongnu.org, =?utf-8?q?Daniel_P_?= =?utf-8?q?=2E_Berrang=C3=A9?= , Juan Quintela , Hailiang Zhang , Stefan Hajnoczi , Fabiano Rosas , Peter Xu , Li Zhijian , Leonardo Bras Subject: [PATCH 00/12] migration: Yet another round of atomic counters Date: Tue, 24 Oct 2023 17:10:30 +0200 Message-ID: <20231024151042.90349-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Goal of the whole series was to be able to move rate_limit logic to not use qemu_file. Goal achieved. Removal of trasnferred atomic counter. After this series, we have three atomic counters: - multifd_bytes - rdma_bytes - qemu_file_trasferred And we only need to setup one (and only one) of these each time that we sent anything. Please review. Later, Juan. Juan Quintela (12): qemu-file: We only call qemu_file_transferred_* on the sending side qemu_file: Use a stat64 for qemu_file_transferred qemu_file: total_transferred is not used anymore migration: Use the number of transferred bytes directly qemu_file: Remove unused qemu_file_transferred() qemu-file: Remove _noflush from qemu_file_transferred_noflush() migration: migration_transferred_bytes() don't need the QEMUFile migration: migration_rate_limit_reset() don't need the QEMUFile qemu-file: Simplify qemu_file_get_error() migration: Use migration_transferred_bytes() migration: Remove transferred atomic counter qemu-file: Make qemu_fflush() return errors migration/migration-stats.h | 16 ++++++-------- migration/qemu-file.h | 27 ++++------------------- migration/block.c | 4 ++-- migration/colo.c | 11 +++------- migration/migration-stats.c | 10 ++++----- migration/migration.c | 17 ++++++--------- migration/multifd.c | 3 --- migration/qemu-file.c | 43 +++++++++++-------------------------- migration/ram.c | 29 +++++++++---------------- migration/rdma.c | 4 +--- migration/savevm.c | 9 ++++---- migration/vmstate.c | 4 ++-- 12 files changed, 56 insertions(+), 121 deletions(-)