[v2,00/12] migration: Yet another round of atomic counters

Message

Juan Quintela Oct. 25, 2023, 9:11 a.m. UTC

Hi

On this v2:
- Redid commint for patch 1
- Every other patch is reviewed now.

Please review pending patch.

Thanks, Juan.

[v1]
Goal of the whole series was to be able to move rate_limit logic to
not use qemu_file.  Goal achieved.

Removal of trasnferred atomic counter.

After this series, we have three atomic counters:
- multifd_bytes
- rdma_bytes
- qemu_file_trasferred

And we only need to setup one (and only one) of these each time that
we sent anything.

Please review.

Later, Juan.

Juan Quintela (12):
  qemu-file: Don't increment qemu_file_transferred at
    qemu_file_fill_buffer
  qemu_file: Use a stat64 for qemu_file_transferred
  qemu_file: total_transferred is not used anymore
  migration: Use the number of transferred bytes directly
  qemu_file: Remove unused qemu_file_transferred()
  qemu-file: Remove _noflush from qemu_file_transferred_noflush()
  migration: migration_transferred_bytes() don't need the QEMUFile
  migration: migration_rate_limit_reset() don't need the QEMUFile
  qemu-file: Simplify qemu_file_get_error()
  migration: Use migration_transferred_bytes()
  migration: Remove transferred atomic counter
  qemu-file: Make qemu_fflush() return errors

 migration/migration-stats.h | 16 ++++++--------
 migration/qemu-file.h       | 27 ++++-------------------
 migration/block.c           |  4 ++--
 migration/colo.c            | 11 +++-------
 migration/migration-stats.c | 10 ++++-----
 migration/migration.c       | 17 ++++++---------
 migration/multifd.c         |  3 ---
 migration/qemu-file.c       | 43 +++++++++++--------------------------
 migration/ram.c             | 29 +++++++++----------------
 migration/rdma.c            |  4 +---
 migration/savevm.c          |  9 ++++----
 migration/vmstate.c         |  4 ++--
 12 files changed, 56 insertions(+), 121 deletions(-)