[RFC,v1,0/1] clipboard sharing implementation for SDL

Message

Kamay Xutax Nov. 8, 2023, 2:21 a.m. UTC

Hello,

This is my first try contributing to QEMU,
and I would like some advices before merging my patch into master branch.

Current implementation works with qemu-vdagent character device.
I decided to ignore QemuClipboardPeer's request function pointer
for my current implementation because I couldn't get any clipboard
requests from the host with,
so instead I've decided to use SDL event loop with SDL_CLIPBOARDUPDATE
and handle the request from here.
I suppose this is the normal behavior, but since I'm not entirely
sure I would like some confirmation or advices about it.

I'm getting also a wanring from the scripts/checkpatch.pl
since I've added a c file for the implementation,
it asks me to update MAINTAINERS, I would gladly put myself here
but I think this decision shouldn't be taken by me.

I'm also up to any corrections if there's errors or something you want
to change in the code.

Thank you.

Kamay Xutax (1):
  ui/sdl2: clipboard sharing implementation for SDL

 include/ui/sdl2.h   |   5 ++
 meson.build         |   1 +
 ui/meson.build      |   1 +
 ui/sdl2-clipboard.c | 147 ++++++++++++++++++++++++++++++++++++++++++++
 ui/sdl2.c           |   8 +++
 5 files changed, 162 insertions(+)
 create mode 100644 ui/sdl2-clipboard.c

Comments

Markus Armbruster Nov. 9, 2023, 7:01 a.m. UTC | #1

Kamay Xutax <[e-mail]> writes:

> Hello,
>
> This is my first try contributing to QEMU,

Welcome!

> and I would like some advices before merging my patch into master branch.

First piece of advice: it's a busy mailing list, and to get people's
attention, cc: them.  For a patch, you want to cc: maintainers of the
code you patch.  To find them, use scripts/get_maintainer.pl and
exercise judgement.  Let me show you:

    $ scripts/get_maintainer.pl ./0001-*patch

    Gerd Hoffmann <[e-mail]> (odd fixer:Graphics)
    "Marc-André Lureau" <[e-mail]> (odd fixer:Graphics)
    Paolo Bonzini <[e-mail]> (maintainer:Meson)
    "Daniel P. Berrangé" <[e-mail]> (reviewer:Meson)
    Thomas Huth <[e-mail]> (reviewer:Meson)
    "Philippe Mathieu-Daudé" <[e-mail]> (reviewer:Meson)
    [e-mail] (open list:All patches CC here)

Since the patch's Meson part is straightforward, I'd just cc: the two
Graphics people,  I'm doing it in this message, so you don't have to.

[...]