[v2,0/2] s390x/pci: small set of fixes

Message

Matthew Rosato Nov. 10, 2023, 5:51 p.m. UTC

The following set of changes are associated with issues exposed by testing
of the 'vfio: Adopt iommufd' series.

The first patch fixes an existing assumption that a vfio device will always
have a group fd (which is no longer true if cdev is used, which can only
happen once the iommufd backend is used).  This patch really only needs to
go into 8.2 if the 'vfio: Adopt iommufd' series does (but would be fine to 
go into 8.2 without it too).

The second patch fixes an issue where we do not detect that a vfio DMA limit
was never read from vfio.  This is actually an existing bug as it's possible
for an older host kernel to be missing this support today; so ideally this one
should be targeted for 8.2 regardless. 

Changes for v2:
- minor style changes (Phil, Thomas)

Matthew Rosato (2):
  s390x/pci: bypass vfio DMA counting when using cdev
  s390x/pci: only limit DMA aperture if vfio DMA limit reported

 hw/s390x/s390-pci-vfio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Thomas Huth Nov. 13, 2023, 6:29 a.m. UTC | #1

On 10/11/2023 18.51, Matthew Rosato wrote:
> The following set of changes are associated with issues exposed by testing
> of the 'vfio: Adopt iommufd' series.
> 
> The first patch fixes an existing assumption that a vfio device will always
> have a group fd (which is no longer true if cdev is used, which can only
> happen once the iommufd backend is used).  This patch really only needs to
> go into 8.2 if the 'vfio: Adopt iommufd' series does (but would be fine to
> go into 8.2 without it too).
> 
> The second patch fixes an issue where we do not detect that a vfio DMA limit
> was never read from vfio.  This is actually an existing bug as it's possible
> for an older host kernel to be missing this support today; so ideally this one
> should be targeted for 8.2 regardless.
> 
> Changes for v2:
> - minor style changes (Phil, Thomas)
> 
> Matthew Rosato (2):
>    s390x/pci: bypass vfio DMA counting when using cdev
>    s390x/pci: only limit DMA aperture if vfio DMA limit reported
> 
>   hw/s390x/s390-pci-vfio.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

Thank you, queued them now!

  Thomas

Eric Farman Nov. 13, 2023, 2:49 p.m. UTC | #2

On Fri, 2023-11-10 at 12:51 -0500, Matthew Rosato wrote:
> The following set of changes are associated with issues exposed by
> testing
> of the 'vfio: Adopt iommufd' series.

...snip...

> Matthew Rosato (2):
>   s390x/pci: bypass vfio DMA counting when using cdev
>   s390x/pci: only limit DMA aperture if vfio DMA limit reported
> 
>  hw/s390x/s390-pci-vfio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Apologies for missing v1 while I was out, but FWIW, for the series:

Reviewed-by: Eric Farman <[e-mail]>