mbox series

[v2,0/2] vhost-scsi: Support worker ioctls

Message ID 20231127002834.8670-1-michael.christie@oracle.com (mailing list archive)
Headers show
Series vhost-scsi: Support worker ioctls | expand

Message

Mike Christie Nov. 27, 2023, 12:28 a.m. UTC 
The following patches allow users to configure the vhost worker threads
for vhost-scsi. With vhost-net we get a worker thread per rx/tx virtqueue
pair, but for vhost-scsi we get one worker for all workqueues. This
becomes a bottlneck after 2 queues are used.

In the upstream linux kernel commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/vhost/vhost.c?id=c1ecd8e9500797748ae4f79657971955d452d69d

we enabled the vhost layer to be able to create a worker thread and
attach it to a virtqueue.

This patchset adds support to vhost-scsi to use these ioctls so we are
no longer limited to the single worker.

v2:
- Make config option a bool instead of an int.

Comments

Stefan Hajnoczi Nov. 29, 2023, 1:43 p.m. UTC | #1 
On Sun, Nov 26, 2023 at 06:28:32PM -0600, Mike Christie wrote:
> The following patches allow users to configure the vhost worker threads
> for vhost-scsi. With vhost-net we get a worker thread per rx/tx virtqueue
> pair, but for vhost-scsi we get one worker for all workqueues. This
> becomes a bottlneck after 2 queues are used.
> 
> In the upstream linux kernel commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/vhost/vhost.c?id=c1ecd8e9500797748ae4f79657971955d452d69d
> 
> we enabled the vhost layer to be able to create a worker thread and
> attach it to a virtqueue.
> 
> This patchset adds support to vhost-scsi to use these ioctls so we are
> no longer limited to the single worker.
> 
> v2:
> - Make config option a bool instead of an int.
> 
> 

Aside from Stefano's comment asking for a warning when the kernel
doesn't support the vhost worker ioctl:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>