| Message ID | 20231211175215.3216667-1-nabihestefan@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Implementation of NPI Mailbox and GMAC Networking Module | expand |
On Mon, 11 Dec 2023 at 17:52, Nabih Estefan <nabihestefan@google.com> wrote: > > From: Nabih Estefan Diaz <nabihestefan@google.com> > > [Changes since v6] > Remove the Change-Ids from the commit messages. > This doesn't compile: ../../hw/net/npcm_gmac.c:889:43: error: too few arguments to function call, expected 6, have 5 dev->id, gmac); ^ /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/include/net/net.h:159:11: note: 'qemu_new_nic' declared here NICState *qemu_new_nic(NetClientInfo *info, ^ 1 error generated. Please make sure you've rebased the series on the most recent head-of-git. (In this case you are missing the necessary changes to cope with commit 7d0fefdf81f5 which added an extra argument to this function.) thanks -- PMM
On Thu, 14 Dec 2023 at 11:43, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Mon, 11 Dec 2023 at 17:52, Nabih Estefan <nabihestefan@google.com> wrote: > > > > From: Nabih Estefan Diaz <nabihestefan@google.com> > > > > [Changes since v6] > > Remove the Change-Ids from the commit messages. > > > > This doesn't compile: > > ../../hw/net/npcm_gmac.c:889:43: error: too few arguments to function > call, expected 6, have 5 > dev->id, gmac); > ^ > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/include/net/net.h:159:11: > note: 'qemu_new_nic' declared here > NICState *qemu_new_nic(NetClientInfo *info, > ^ > 1 error generated. > > Please make sure you've rebased the series on the most > recent head-of-git. (In this case you are missing the > necessary changes to cope with commit 7d0fefdf81f5 > which added an extra argument to this function.) Also, when you're resending please check your cc list. You have had a typo in Jason Wang's email address for I think every version of this series, which means when I hit 'reply all' I get a bounce message. The email address in MAINTAINERS for him has the correct spelling. thanks -- PMM
From: Nabih Estefan Diaz <nabihestefan@google.com> [Changes since v6] Remove the Change-Ids from the commit messages. [Changes since v5] Undid remove of some qtests that seem to have been caused by a merge conflict. [Changes since v4] Added Signed-off-by tag and fixed patch 4 commit message as suggested by Peter Maydell (peter.maydell@linaro.org) [Changes since v3] Fixed comments from Hao Wu (wuhaotsh@google.com) [Changes since v2] Fixed bugs related to the RC functionality of the GMAC. Added and squashed patches related to that. [Changes since v1] Fixed some errors in formatting. Fixed a merge error that I didn't see in v1. Removed Nuvoton 8xx references since that is a separate patch set. [Original Cover] Creates NPI Mailbox Module with data verification for read and write (internal and external), wiring to the Nuvoton SoC, and QTests. Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors and registers. Also includes QTests for the different functionalities. Hao Wu (5): hw/misc: Add Nuvoton's PCI Mailbox Module hw/arm: Add PCI mailbox module to Nuvoton SoC hw/misc: Add qtest for NPCM7xx PCI Mailbox hw/net: Add NPCMXXX GMAC device hw/arm: Add GMAC devices to NPCM7XX SoC Nabih Estefan Diaz (6): tests/qtest: Creating qtest for GMAC Module include/hw/net: Implemented Classes and Masks for GMAC Descriptors hw/net: General GMAC Implementation hw/net: GMAC Rx Implementation hw/net: GMAC Tx Implementation tests/qtest: Adding PCS Module test to GMAC Qtest docs/system/arm/nuvoton.rst | 2 + hw/arm/npcm7xx.c | 53 +- hw/misc/meson.build | 1 + hw/misc/npcm7xx_pci_mbox.c | 324 ++++++++++ hw/misc/trace-events | 5 + hw/net/meson.build | 2 +- hw/net/npcm_gmac.c | 942 ++++++++++++++++++++++++++++ hw/net/trace-events | 19 + include/hw/arm/npcm7xx.h | 4 + include/hw/misc/npcm7xx_pci_mbox.h | 81 +++ include/hw/net/npcm_gmac.h | 340 ++++++++++ tests/qtest/meson.build | 3 + tests/qtest/npcm7xx_pci_mbox-test.c | 238 +++++++ tests/qtest/npcm_gmac-test.c | 341 ++++++++++ 14 files changed, 2351 insertions(+), 4 deletions(-) create mode 100644 hw/misc/npcm7xx_pci_mbox.c create mode 100644 hw/net/npcm_gmac.c create mode 100644 include/hw/misc/npcm7xx_pci_mbox.h create mode 100644 include/hw/net/npcm_gmac.h create mode 100644 tests/qtest/npcm7xx_pci_mbox-test.c create mode 100644 tests/qtest/npcm_gmac-test.c