From patchwork Thu Dec 21 19:24:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 13502589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F29E8C35274 for ; Thu, 21 Dec 2023 19:25:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGOfG-0001LH-A2; Thu, 21 Dec 2023 14:25:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGOfD-0001L2-OF for qemu-devel@nongnu.org; Thu, 21 Dec 2023 14:24:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGOfC-0001pI-BK for qemu-devel@nongnu.org; Thu, 21 Dec 2023 14:24:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703186697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YXbTLuszSKAj4bIkUqFT97yQ3L2RuqIE0uO8DpxsN3M=; b=Uh5FqKzMEKOGO44/6ZBLBv2qLc9DWhEq2rtISZYcL4ekq+XQjvY4AdtrKXF7iH+NdDIsyc QcIyyL1We93M84EsBakkZBxpZxg1qFfKFcxdaSAX4ZvGvlaXjjpgjk82efyUG4fw2pGEBn Expsn0ZzNEo5XnmkFSbGtVJwn72M+eE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-4h1v6HfxPO-f3iFt4vFzAg-1; Thu, 21 Dec 2023 14:24:54 -0500 X-MC-Unique: 4h1v6HfxPO-f3iFt4vFzAg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 41EF33C02568; Thu, 21 Dec 2023 19:24:54 +0000 (UTC) Received: from localhost (unknown [10.39.194.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97C06492BE6; Thu, 21 Dec 2023 19:24:53 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org, Kevin Wolf Cc: Juan Quintela , Vladimir Sementsov-Ogievskiy , pbonzini@redhat.com, Peter Xu , qemu-block@nongnu.org, Hanna Reitz , Fabiano Rosas , Leonardo Bras , Eric Blake , Stefan Hajnoczi , Fam Zheng Subject: [PATCH v3 0/6] qemu-iotests fixes for Kevin's block tree Date: Thu, 21 Dec 2023 14:24:46 -0500 Message-ID: <20231221192452.1785567-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v3: - Add aio_wait_kick() into nbd_read_eof() to avoid race with nbd_drained_poll() [Kevin] v2: - Drop useless if (client->quiesing) check [Kevin] - run qio_channel_read_wake() in export AioContext to avoid race [Kevin] - Introduce nbd_client_put_nonzero() optimization [Paolo] - Reach goto label disconnect with client->lock taken [Paolo] - Add doc comment explaining nbd_co_receive_request() loop in nbd_trip() [Kevin] Kevin merged several of my outstanding multi-queue block layer patch series and found that qemu-iotests -qcow2 was broken. This patch series fixes the block branch. Most of the fixes are easy but the NBD server required deeper debugging and thread-safety fixes. The NBD server patches can be inserted before "aio: make aio_context_acquire()/aio_context_release() a no-op" to preserve bisectability. The other patches are fixups that can be squashed into the original patches. Stefan Hajnoczi (6): fixup block-coroutine-wrapper: use qemu_get_current_aio_context() fixup block: remove AioContext locking fixup scsi: only access SCSIDevice->requests from one thread nbd/server: avoid per-NBDRequest nbd_client_get/put() nbd/server: only traverse NBDExport->clients from main loop thread nbd/server: introduce NBDClient->lock to protect fields hw/scsi/scsi-bus.c | 3 +- migration/block.c | 7 ++ nbd/server.c | 208 ++++++++++++++++++++++++++-------- tests/qemu-iotests/051.pc.out | 4 +- 4 files changed, 173 insertions(+), 49 deletions(-)