mbox series

[v4,0/5] Virtio dmabuf improvements

Message ID 20240219143423.272012-1-aesteve@redhat.com (mailing list archive)
Headers show
Series Virtio dmabuf improvements | expand

Message

Albert Esteve Feb. 19, 2024, 2:34 p.m. UTC
v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html
v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1014615.html
v3: Virtio dmabuf improvements
v3 -> v4
  - Changed GMutex by QemuMutex in virtio-dmabuf
  - Made the value at VirtioSharedObject an union
    to make naming more clear
  - Added some documentation

Various improvements for the virtio-dmabuf module.
This patch includes:

- Check for ownership before allowing a vhost device
  to remove an object from the table.
- Properly cleanup shared resources if a vhost device
  object gets cleaned up.
- Rename virtio dmabuf functions to `virtio_dmabuf_*`

Albert Esteve (5):
  hw/virtio: check owner for removing objects
  hw/virtio: document SharedObject structures
  hw/virtio: change dmabuf mutex to QemuMutex
  hw/virtio: cleanup shared resources
  hw/virtio: rename virtio dmabuf API

 docs/interop/vhost-user.rst       |  4 +-
 hw/display/virtio-dmabuf.c        | 98 +++++++++++++++++++------------
 hw/virtio/vhost-user.c            | 31 +++++++---
 hw/virtio/vhost.c                 |  3 +
 hw/virtio/virtio.c                |  3 +
 include/hw/virtio/virtio-dmabuf.h | 73 +++++++++++++++++------
 tests/unit/test-virtio-dmabuf.c   | 82 +++++++++++++++++++-------
 7 files changed, 211 insertions(+), 83 deletions(-)

Comments

Michael S. Tsirkin March 12, 2024, 6:23 p.m. UTC | #1
On Mon, Feb 19, 2024 at 03:34:18PM +0100, Albert Esteve wrote:
> v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html
> v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1014615.html
> v3: Virtio dmabuf improvements
> v3 -> v4
>   - Changed GMutex by QemuMutex in virtio-dmabuf
>   - Made the value at VirtioSharedObject an union
>     to make naming more clear
>   - Added some documentation

Dropped everything except patch 1 for now.

> Various improvements for the virtio-dmabuf module.
> This patch includes:
> 
> - Check for ownership before allowing a vhost device
>   to remove an object from the table.
> - Properly cleanup shared resources if a vhost device
>   object gets cleaned up.
> - Rename virtio dmabuf functions to `virtio_dmabuf_*`
> 
> Albert Esteve (5):
>   hw/virtio: check owner for removing objects
>   hw/virtio: document SharedObject structures
>   hw/virtio: change dmabuf mutex to QemuMutex
>   hw/virtio: cleanup shared resources
>   hw/virtio: rename virtio dmabuf API
> 
>  docs/interop/vhost-user.rst       |  4 +-
>  hw/display/virtio-dmabuf.c        | 98 +++++++++++++++++++------------
>  hw/virtio/vhost-user.c            | 31 +++++++---
>  hw/virtio/vhost.c                 |  3 +
>  hw/virtio/virtio.c                |  3 +
>  include/hw/virtio/virtio-dmabuf.h | 73 +++++++++++++++++------
>  tests/unit/test-virtio-dmabuf.c   | 82 +++++++++++++++++++-------
>  7 files changed, 211 insertions(+), 83 deletions(-)
> 
> -- 
> 2.43.1
Albert Esteve March 13, 2024, 8 a.m. UTC | #2
On Tue, Mar 12, 2024 at 7:23 PM Michael S. Tsirkin <mst@redhat.com> wrote:

> On Mon, Feb 19, 2024 at 03:34:18PM +0100, Albert Esteve wrote:
> > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html
> > v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1014615.html
> > v3: Virtio dmabuf improvements
> > v3 -> v4
> >   - Changed GMutex by QemuMutex in virtio-dmabuf
> >   - Made the value at VirtioSharedObject an union
> >     to make naming more clear
> >   - Added some documentation
>
> Dropped everything except patch 1 for now.
>

Got it. Thanks!


>
> > Various improvements for the virtio-dmabuf module.
> > This patch includes:
> >
> > - Check for ownership before allowing a vhost device
> >   to remove an object from the table.
> > - Properly cleanup shared resources if a vhost device
> >   object gets cleaned up.
> > - Rename virtio dmabuf functions to `virtio_dmabuf_*`
> >
> > Albert Esteve (5):
> >   hw/virtio: check owner for removing objects
> >   hw/virtio: document SharedObject structures
> >   hw/virtio: change dmabuf mutex to QemuMutex
> >   hw/virtio: cleanup shared resources
> >   hw/virtio: rename virtio dmabuf API
> >
> >  docs/interop/vhost-user.rst       |  4 +-
> >  hw/display/virtio-dmabuf.c        | 98 +++++++++++++++++++------------
> >  hw/virtio/vhost-user.c            | 31 +++++++---
> >  hw/virtio/vhost.c                 |  3 +
> >  hw/virtio/virtio.c                |  3 +
> >  include/hw/virtio/virtio-dmabuf.h | 73 +++++++++++++++++------
> >  tests/unit/test-virtio-dmabuf.c   | 82 +++++++++++++++++++-------
> >  7 files changed, 211 insertions(+), 83 deletions(-)
> >
> > --
> > 2.43.1
>
>