[RFC,0/3] target/arm: Implement FEAT_NMI and FEAT_GICv3_NMI

Message

Jinjie Ruan Feb. 20, 2024, 12:17 p.m. UTC

This patch set implements FEAT_NMI and FEAT_GICv3_NMI for armv8. These
introduce support for a new category of interrupts in the architecture
which we can use to provide NMI like functionality.

There are two modes for using this FEAT_NMI. When PSTATE.ALLINT or
PSTATE.SP & SCTLR_ELx.SCTLR_SPINTMASK is set, any entry to ELx causes all
interrupts including those with superpriority to be masked on entry to ELn
until the mask is explicitly removed by software or hardware. PSTATE.ALLINT
can be managed by software using the new register control ALLINT.ALLINT.
Independent controls are provided for this feature at each EL, usage at EL1
should not disrupt EL2 or EL3.

I have tested it with the following linux patches which try to support
FEAT_NMI in linux kernel:

>-------https://lore.kernel.org/linux-arm-kernel/Y4sH5qX5bK9xfEBp@lpieralisi/T/#mb4ba4a2c045bf72c10c2202c1dd1b82d3240dc88

In the test, SGI, PPI and SPI interrupts can all be set to have super priority
to be converted to a hardware NMI interrupt. The SGI is tested with kernel
IPI as NMI framework, and the PPI interrupt is tested with "perf top" command
with hardware NMI enabled, and the PPI interrupt is tested with a custom
test module, in which NMI interrupts can be received and transmitted normally.

Jinjie Ruan (3):
  target/arm: Implement FEAT_NMI to support Non-maskable Interrupt
  target/arm: Add NMI exception and handle PSTATE.ALLINT on taking an
    exception
  hw/intc/arm_gicv3: Implement FEAT_GICv3_NMI feature to support
    FEAT_NMI

 hw/arm/virt.c                      |  2 +
 hw/intc/arm_gicv3.c                | 61 ++++++++++++++++++++++++++----
 hw/intc/arm_gicv3_common.c         |  4 ++
 hw/intc/arm_gicv3_cpuif.c          | 57 ++++++++++++++++++++++++++--
 hw/intc/arm_gicv3_dist.c           | 39 +++++++++++++++++++
 hw/intc/arm_gicv3_redist.c         | 23 +++++++++++
 hw/intc/gicv3_internal.h           |  5 +++
 include/hw/core/cpu.h              |  1 +
 include/hw/intc/arm_gic_common.h   |  1 +
 include/hw/intc/arm_gicv3_common.h |  6 +++
 target/arm/cpu-features.h          |  5 +++
 target/arm/cpu-qom.h               |  1 +
 target/arm/cpu.c                   | 43 ++++++++++++++++++---
 target/arm/cpu.h                   | 12 +++++-
 target/arm/cpu64.c                 | 31 +++++++++++++++
 target/arm/helper.c                | 58 ++++++++++++++++++++++++++++
 target/arm/internals.h             |  4 ++
 target/arm/tcg/a64.decode          |  1 +
 target/arm/tcg/cpu64.c             | 11 ++++++
 target/arm/tcg/helper-a64.c        | 25 ++++++++++++
 target/arm/tcg/helper-a64.h        |  1 +
 target/arm/tcg/translate-a64.c     | 10 +++++
 22 files changed, 383 insertions(+), 18 deletions(-)