[v5,00/22] parallels: Add full dirty bitmap support

Message

Alexander Ivanov March 11, 2024, 6:18 p.m. UTC

Parallels format driver:
* make some preparation
* add dirty bitmap saving
* make dirty bitmap RW
* fix broken checks
* refactor leak check
* add parallels format support to several tests

You could find these patches in my repo:
https://github.com/AlexanderIvanov-Virtuozzo/qemu/tree/parallels-v5

v5:
6: Returned a comment about fallocate.
10: Added a motivation of used_bitmap usage to the commit message.
11: Renamed 'limit' variable. Added a few error messages. Fixed
    'remaining' value by extension header size. Simplified bh and l1_table
    pointer calculation. Added clusters cleaning after error. Add return
    value to parallels_store_persistent_dirty_bitmaps().
12: New patch, all the next patches will be shifted by 1. Added header
    unclean check to dirty bitmap loading.
13: Placed dirty bitmap loading after used bitmap initialization.
14: New patch, all the next patches will be shifted by 2. Preserved
    extensions cluster for non-transient extensions.
16: (previous numeration): Dropped the patch because the next patch deleted
    all the code of this patch. All the next patches will be shifted by 1.
18: Moved used bitmap parallels_check_unused_clusters() to parallels_check_leak().
19: Removed redundant bdrv_pwrite_zeroes() (see a note in the commit message).
    Added a break to outside-of-image clusters at image opening.

v4:
4: A new patch with limitation of search in parallels_mark_used.
5: Previously 4. Search is limited to (cluster_index + count).
6: Previously 5. Added GRAPH_RDLOCK annotation, added a note in the commit
   message.
11: Previously 10. Added GRAPH_RDLOCK annotation.
16-18: Added GRAPH_RDLOCK annotations.

v3:
1: Fixed the order of g_free() and s->used_bmap = NULL.
3,4: Made mark_used() a global function before mark_unused() addition. In
     this way we can avoid compilation warnings.
5-9: Patches shifted.
11: Added GRAPH_RDLOCK annotation to parallels_inactivate(). Guard
    parallels_close() with GRAPH_RDLOCK_GUARD_MAINLOOP().
12-21: Patches shifted.

v2:
1: New patch to fix double free error.
4: Fixed clusters leaks.
15: Fixed (end_off != s->used_bmap_size) handling in parallels_truncate_unused_clusters().
16,17: Changed the sequence of the patches - in this way we have correct leaks check.

Alexander Ivanov (21):
  parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap()
  parallels: Move inactivation code to a separate function
  parallels: Make mark_used() a global function
  parallels: Limit search in parallels_mark_used to the last marked
    claster
  parallels: Add parallels_mark_unused() helper
  parallels: Move host clusters allocation to a separate function
  parallels: Set data_end value in parallels_check_leak()
  parallels: Recreate used bitmap in parallels_check_leak()
  parallels: Add a note about used bitmap in parallels_check_duplicate()
  parallels: Create used bitmap even if checks needed
  parallels: Add dirty bitmaps saving
  parallels: Let image extensions work in RW mode
  parallels: Preserve extensions cluster for non-transient extensions
  parallels: Handle L1 entries equal to one
  parallels: Make a loaded dirty bitmap persistent
  parallels: Reverse a conditional in parallels_check_leak() to reduce
    indents
  parallels: Check unused clusters in parallels_check_leak()
  parallels: Remove unnecessary data_end field
  tests: Add parallels images support to test 165
  tests: Turned on 256, 299, 304 and block-status-cache for parallels
    format
  tests: Add parallels format support to image-fleecing

Denis V. Lunev (1):
  parallels: drop dirty bitmap data if the image was not properly closed

 block/parallels-ext.c                       | 243 ++++++++++++-
 block/parallels.c                           | 367 ++++++++++++--------
 block/parallels.h                           |  14 +-
 tests/qemu-iotests/165                      |  40 ++-
 tests/qemu-iotests/256                      |   2 +-
 tests/qemu-iotests/299                      |   2 +-
 tests/qemu-iotests/304                      |   2 +-
 tests/qemu-iotests/tests/block-status-cache |   2 +-
 tests/qemu-iotests/tests/image-fleecing     |  13 +-
 9 files changed, 502 insertions(+), 183 deletions(-)