| Message ID | 20240416185939.37984-1-philmd@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines | expand |
Hi, Michael, I expect this series to go via your maintainer tree :) Thanks, Phil. On 16/4/24 20:59, Philippe Mathieu-Daudé wrote: > Series fully reviewed. > Philippe Mathieu-Daudé (22): > hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines > hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine > hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag > hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag > hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size > hw/acpi/ich9: Remove 'memory-hotplug-support' property > hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug' > hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine > target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' > hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded > hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() > hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid() > hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm > hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() > hw/mem/memory-device: Remove legacy_align from > memory_device_pre_plug() > hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine > hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob > hw/i386/pc: Remove PCMachineClass::rsdp_in_ram > hw/i386/acpi: Remove AcpiBuildState::rsdp field > hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine > target/i386: Remove X86CPU::kvm_no_smi_migration field > hw/i386/pc: Replace PCMachineClass::acpi_data_size by > PC_ACPI_DATA_SIZE
On 16/4/24 20:59, Philippe Mathieu-Daudé wrote: > Series fully reviewed. Ping, is there some issue holding this series? > Philippe Mathieu-Daudé (22): > hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines > hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine > hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag > hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag > hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size > hw/acpi/ich9: Remove 'memory-hotplug-support' property > hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug' > hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine > target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' > hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded > hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() > hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid() > hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm > hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() > hw/mem/memory-device: Remove legacy_align from > memory_device_pre_plug() > hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine > hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob > hw/i386/pc: Remove PCMachineClass::rsdp_in_ram > hw/i386/acpi: Remove AcpiBuildState::rsdp field > hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine > target/i386: Remove X86CPU::kvm_no_smi_migration field > hw/i386/pc: Replace PCMachineClass::acpi_data_size by > PC_ACPI_DATA_SIZE
ping^2 On 6/5/24 16:29, Philippe Mathieu-Daudé wrote: > On 16/4/24 20:59, Philippe Mathieu-Daudé wrote: >> Series fully reviewed. > > Ping, is there some issue holding this series? > >> Philippe Mathieu-Daudé (22): >> hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines >> hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine >> hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag >> hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag >> hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size >> hw/acpi/ich9: Remove 'memory-hotplug-support' property >> hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug' >> hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine >> target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' >> hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded >> hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() >> hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid() >> hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm >> hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() >> hw/mem/memory-device: Remove legacy_align from >> memory_device_pre_plug() >> hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine >> hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob >> hw/i386/pc: Remove PCMachineClass::rsdp_in_ram >> hw/i386/acpi: Remove AcpiBuildState::rsdp field >> hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine >> target/i386: Remove X86CPU::kvm_no_smi_migration field >> hw/i386/pc: Replace PCMachineClass::acpi_data_size by >> PC_ACPI_DATA_SIZE
Series fully reviewed. Since v3: - Deprecate up to 2.12 (Thomas) Since v2: - Addressed Zhao review comments Since v1: - Addressed Zhao and Thomas review comments Kill legacy code, because we need to evolve. I ended there via dynamic machine -> ICH9 -> legacy ACPI... This should also help Igor cleanups: http://lore.kernel.org/qemu-devel/20240326171632.3cc7533d@imammedo.users.ipa.redhat.com/ Philippe Mathieu-Daudé (22): hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size hw/acpi/ich9: Remove 'memory-hotplug-support' property hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug' hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid() hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug() hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob hw/i386/pc: Remove PCMachineClass::rsdp_in_ram hw/i386/acpi: Remove AcpiBuildState::rsdp field hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine target/i386: Remove X86CPU::kvm_no_smi_migration field hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE docs/about/deprecated.rst | 4 +- docs/about/removed-features.rst | 2 +- hw/usb/hcd-xhci.h | 4 +- include/hw/firmware/smbios.h | 3 +- include/hw/i386/pc.h | 22 ------ include/hw/mem/memory-device.h | 2 +- include/hw/mem/pc-dimm.h | 3 +- target/i386/cpu.h | 3 - target/i386/kvm/kvm-cpu.h | 41 ---------- hw/acpi/ich9.c | 46 ++--------- hw/arm/virt.c | 5 +- hw/i386/acpi-build.c | 95 ++--------------------- hw/i386/fw_cfg.c | 3 +- hw/i386/pc.c | 107 ++++---------------------- hw/i386/pc_piix.c | 102 +----------------------- hw/loongarch/virt.c | 4 +- hw/mem/memory-device.c | 12 +-- hw/mem/pc-dimm.c | 6 +- hw/ppc/spapr.c | 2 +- hw/riscv/virt.c | 2 +- hw/smbios/smbios.c | 13 +--- hw/usb/hcd-xhci-nec.c | 4 - hw/usb/hcd-xhci-pci.c | 4 +- hw/usb/hcd-xhci.c | 42 ++-------- hw/virtio/virtio-md-pci.c | 2 +- target/i386/cpu.c | 2 - target/i386/kvm/kvm-cpu.c | 3 +- target/i386/kvm/kvm.c | 7 +- tests/avocado/mem-addr-space-check.py | 9 +-- 29 files changed, 69 insertions(+), 485 deletions(-) delete mode 100644 target/i386/kvm/kvm-cpu.h