| Message ID | 20240418100433.1085447-1-zhao1.liu@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean | expand |
On 18/4/24 12:04, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > --- > Zhao Liu (3): > hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean > hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean > hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean Series: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, 18 Apr 2024 14:06:39 +0200 Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 18/4/24 12:04, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > --- > > Zhao Liu (3): > > hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean > > hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean > > hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean > > Series: > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
On 18/4/24 12:04, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > --- > Zhao Liu (3): > hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean > hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean > hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean Since Jonathan Ack'ed the series, I'm queuing it via my hw-misc tree.
On Fri, 19 Apr 2024 17:40:07 +0200 Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 18/4/24 12:04, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > --- > > Zhao Liu (3): > > hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean > > hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean > > hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean > > Since Jonathan Ack'ed the series, I'm queuing it via my hw-misc tree. > Thanks, J
From: Zhao Liu <zhao1.liu@intel.com> Hi list, This series is the followup of the previous fix [1] to improve the error handling. As error.h suggested, the best practice for callee is to return something to indicate success / failure instead of dereferencing @errp. Thus make cxl_doe_cdat_init() as well as ct3_load_cdat() and ct3_build_cdat() return boolean. [1]: https://lore.kernel.org/qemu-devel/20240221094317.994454-1-zhao1.liu@linux.intel.com/ Thanks, Zhao --- Zhao Liu (3): hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean hw/cxl/cxl-cdat.c | 28 +++++++++++++++------------- hw/mem/cxl_type3.c | 3 +-- hw/pci-bridge/cxl_upstream.c | 3 +-- include/hw/cxl/cxl_component.h | 2 +- 4 files changed, 18 insertions(+), 18 deletions(-)