mbox series

[v2,0/2] riscv,kvm: remove another strerrorname_np()

Message ID 20240424202425.534338-1-dbarboza@ventanamicro.com (mailing list archive)
Headers show
Series riscv,kvm: remove another strerrorname_np() | expand

Message

Daniel Henrique Barboza April 24, 2024, 8:24 p.m. UTC
Hi,

In this new version a small change suggested by Phil was made in patch
2. No other changes made.

Note: checkpatch.pl is nagging quite a bit about the checkpatch.pl change
this time, claiming that I'm adding a line > 90 chars when in reality the
line has 80 chars:

ERROR: line over 90 characters
#39: FILE: scripts/checkpatch.pl:3082:
+			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);

total: 1 errors, 0 warnings, 9 lines checked

I supposed it's counting each TAB as more than one char. Let me know if
I need to care about this error and I'll send a v3.


Changes from v1:
- patch 2:
  - move the strerrorname_np() check to the "non-portable libc calls"
    section
- v1 link: https://lore.kernel.org/qemu-riscv/20240424094700.453356-1-dbarboza@ventanamicro.com/

Daniel Henrique Barboza (2):
  target/riscv/kvm: remove sneaky strerrorname_np() instance
  checkpatch.pl: forbid strerrorname_np()

 scripts/checkpatch.pl      | 3 +++
 target/riscv/kvm/kvm-cpu.c | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Michael Tokarev April 24, 2024, 8:29 p.m. UTC | #1
24.04.2024 23:24, Daniel Henrique Barboza wrote:
> Hi,
> 
> In this new version a small change suggested by Phil was made in patch
> 2. No other changes made.

Applied to trivial-patches tree.

> Note: checkpatch.pl is nagging quite a bit about the checkpatch.pl change
> this time, claiming that I'm adding a line > 90 chars when in reality the
> line has 80 chars:
> 
> ERROR: line over 90 characters
> #39: FILE: scripts/checkpatch.pl:3082:
> +			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
> 
> total: 1 errors, 0 warnings, 9 lines checked
> 
> I supposed it's counting each TAB as more than one char. Let me know if
> I need to care about this error and I'll send a v3.

checkpatch complaining about checkpatch change is nice.
Nope, it is the style used here, all other tests are
like this too, but worse.

/mjt