mbox series

[v4,0/4] target/hexagon: Minor idef-parser cleanup

Message ID 20240523125901.27797-1-anjo@rev.ng (mailing list archive)
Headers show
Series target/hexagon: Minor idef-parser cleanup | expand

Message

Anton Johansson May 23, 2024, 12:58 p.m. UTC
Was running idef-parser with ASAN and noticed we were leaking the
init_list GArray, which is used to hold instruction arguments that may
need initialization.  This patchset fixes the leak, removes unused
macros and undefined functions, and simplifies gen_inst_init_args() to
only handle predicate values.

Changes in v2:
  * Update comment in 3rd patch
  * Follow style guide in 4th patch

Changes in v3/v4:
  * Added reviewed-bys

Anton Johansson (4):
  target/hexagon: idef-parser remove unused defines
  target/hexagon: idef-parser remove undefined functions
  target/hexagon: idef-parser fix leak of init_list
  target/hexagon: idef-parser simplify predicate init

 target/hexagon/idef-parser/idef-parser.h    | 10 ------
 target/hexagon/idef-parser/idef-parser.y    |  2 --
 target/hexagon/idef-parser/parser-helpers.c | 35 +++++++++++++--------
 target/hexagon/idef-parser/parser-helpers.h | 13 --------
 4 files changed, 22 insertions(+), 38 deletions(-)