mbox series

[00/11] target/i386: fixes for INHIBIT_IRQ, TF and RF

Message ID 20240604071833.962574-1-pbonzini@redhat.com (mailing list archive)
Headers show
Series target/i386: fixes for INHIBIT_IRQ, TF and RF | expand

Message

Paolo Bonzini June 4, 2024, 7:18 a.m. UTC 
While Richard pointed out that there _are_ good reasons to use
DISAS_NORETURN in the TCG x86 frontend, most instructions that
use it (VMRUN, HLT, MWAIT, PAUSE) are broken because they do
not do the work that gen_eob() does on INHIBIT_IRQ, EFLAGS.TF
and EFLAGS.RF.

This series tackles this, plus it has a few more fixes for
failures in kvm-unit-tests debug.flat and svm.flat.  Note that
neither of the two completely pass, but the situation is
improved a lot.  Comments are added when things are more
complicated and probably deserve their own series.

Paolo

Paolo Bonzini (11):
  target/i386: fix pushed value of EFLAGS.RF
  target/i386: fix implementation of ICEBP
  target/i386: cleanup HLT helpers
  target/i386: cleanup PAUSE helpers
  target/i386: implement DR7.GD
  target/i386: disable/enable breakpoints on vmentry/vmexit
  target/i386: fix INHIBIT_IRQ/TF/RF handling for VMRUN
  target/i386: fix INHIBIT_IRQ/TF/RF handling for PAUSE
  target/i386: fix TF/RF handling for HLT
  target/i386: document incorrect semantics of watchpoint following
    MOV/POP SS
  target/i386: document use of DISAS_NORETURN

 include/hw/core/tcg-cpu-ops.h        | 15 +++++-
 target/i386/helper.h                 |  5 +-
 target/i386/tcg/helper-tcg.h         |  6 ++-
 accel/tcg/cpu-exec.c                 |  7 ++-
 target/i386/tcg/bpt_helper.c         |  6 +++
 target/i386/tcg/excp_helper.c        | 20 ++++++++
 target/i386/tcg/misc_helper.c        | 14 ++----
 target/i386/tcg/seg_helper.c         | 49 +++++++++++++++++--
 target/i386/tcg/sysemu/bpt_helper.c  | 18 +++++++
 target/i386/tcg/sysemu/misc_helper.c | 17 ++-----
 target/i386/tcg/sysemu/seg_helper.c  | 18 +++++--
 target/i386/tcg/sysemu/svm_helper.c  | 71 +++++++++++++++++++---------
 target/i386/tcg/translate.c          | 37 +++++++++++++++
 target/i386/tcg/decode-new.c.inc     | 19 ++++++--
 target/i386/tcg/emit.c.inc           | 29 ++++++------
 15 files changed, 252 insertions(+), 79 deletions(-)