mbox series

[v3,0/2] Fix coverity issues for AST2700

Message ID 20240625070741.2852946-1-jamin_lin@aspeedtech.com (mailing list archive)
Headers show
Series Fix coverity issues for AST2700 | expand

Message

Jamin Lin June 25, 2024, 7:07 a.m. UTC 
change from v1:
aspeed/soc: coverity defect: DIVIDE_BY_ZERO
aspeed/sdmc: coverity defect: Control flow issues (DEADCODE)

change from v2:
add more commit log from reviewer suggestion, Cédric.

change from v3:
replace qemu_log_mask with assert dram size 0.

Jamin Lin (2):
  aspeed/soc: Fix possible divide by zero
  aspeed/sdmc: Remove extra R_MAIN_STATUS case

 hw/arm/aspeed_ast27x0.c | 2 ++
 hw/misc/aspeed_sdmc.c   | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Cédric Le Goater June 25, 2024, 7:22 a.m. UTC | #1 
Hello Jamin

On 6/25/24 9:07 AM, Jamin Lin wrote:
> change from v1:
> aspeed/soc: coverity defect: DIVIDE_BY_ZERO
> aspeed/sdmc: coverity defect: Control flow issues (DEADCODE)
> 
> change from v2:
> add more commit log from reviewer suggestion, Cédric.
> 
> change from v3:
> replace qemu_log_mask with assert dram size 0.
> 
> Jamin Lin (2):
>    aspeed/soc: Fix possible divide by zero
>    aspeed/sdmc: Remove extra R_MAIN_STATUS case
> 
>   hw/arm/aspeed_ast27x0.c | 2 ++
>   hw/misc/aspeed_sdmc.c   | 1 -
>   2 files changed, 2 insertions(+), 1 deletion(-)
>

LGTM.

Could you please review :

https://lore.kernel.org/qemu-devel/20240625065839.485034-1-clg@redhat.com/T/#u

Thanks,

C.
Jamin Lin June 25, 2024, 7:26 a.m. UTC | #2 
Hi Cedric, 

> -----Original Message-----
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Tuesday, June 25, 2024 3:22 PM
> To: Jamin Lin <jamin_lin@aspeedtech.com>; Peter Maydell
> <peter.maydell@linaro.org>; Steven Lee <steven_lee@aspeedtech.com>; Troy
> Lee <leetroy@gmail.com>; Andrew Jeffery <andrew@codeconstruct.com.au>;
> Joel Stanley <joel@jms.id.au>; open list:ASPEED BMCs
> <qemu-arm@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Subject: Re: [PATCH v3 0/2] Fix coverity issues for AST2700
> 
> Hello Jamin
> 
> On 6/25/24 9:07 AM, Jamin Lin wrote:
> > change from v1:
> > aspeed/soc: coverity defect: DIVIDE_BY_ZERO
> > aspeed/sdmc: coverity defect: Control flow issues (DEADCODE)
> >
> > change from v2:
> > add more commit log from reviewer suggestion, Cédric.
> >
> > change from v3:
> > replace qemu_log_mask with assert dram size 0.
> >
> > Jamin Lin (2):
> >    aspeed/soc: Fix possible divide by zero
> >    aspeed/sdmc: Remove extra R_MAIN_STATUS case
> >
> >   hw/arm/aspeed_ast27x0.c | 2 ++
> >   hw/misc/aspeed_sdmc.c   | 1 -
> >   2 files changed, 2 insertions(+), 1 deletion(-)
> >
> 
> LGTM.
> 
> Could you please review :
> 
Done.
Thanks-Jamin
> https://lore.kernel.org/qemu-devel/20240625065839.485034-1-clg@redhat.co
> m/T/#u
> 
> Thanks,
> 
> C.
>
Cédric Le Goater July 2, 2024, 5:58 a.m. UTC | #3 
On 6/25/24 9:07 AM, Jamin Lin wrote:
> change from v1:
> aspeed/soc: coverity defect: DIVIDE_BY_ZERO
> aspeed/sdmc: coverity defect: Control flow issues (DEADCODE)
> 
> change from v2:
> add more commit log from reviewer suggestion, Cédric.
> 
> change from v3:
> replace qemu_log_mask with assert dram size 0.
> 
> Jamin Lin (2):
>    aspeed/soc: Fix possible divide by zero
>    aspeed/sdmc: Remove extra R_MAIN_STATUS case
> 
>   hw/arm/aspeed_ast27x0.c | 2 ++
>   hw/misc/aspeed_sdmc.c   | 1 -
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 



Applied to aspeed-next.

Thanks,

C.