| Message ID | 20240715-cursor-v3-0-afa5b9492dbf@daynix.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ui/cocoa: Add cursor composition | expand |
On 15/7/24 07:25, Akihiko Odaki wrote: > Add accelerated cursor composition to ui/cocoa. This does not only > improve performance for display devices that exposes the capability to > the guest according to dpy_cursor_define_supported(), but fixes the > cursor display for devices that unconditionally expects the availability > of the capability (e.g., virtio-gpu). > > The common pattern to implement accelerated cursor composition is to > replace the cursor and warp it so that the replaced cursor is shown at > the correct position on the guest display for relative pointer devices. > Unfortunately, ui/cocoa cannot do the same because warping the cursor > position interfers with the mouse input so it uses CALayer instead; > although it is not specialized for cursor composition, it still can > compose images with hardware acceleration. > Akihiko Odaki (4): > ui/cocoa: Release CGColorSpace > ui/console: Convert mouse visibility parameter into bool > ui/cocoa: Add cursor composition > ui/console: Remove dpy_cursor_define_supported() No issue with rudimentary testing, so series queued, thanks!
Add accelerated cursor composition to ui/cocoa. This does not only improve performance for display devices that exposes the capability to the guest according to dpy_cursor_define_supported(), but fixes the cursor display for devices that unconditionally expects the availability of the capability (e.g., virtio-gpu). The common pattern to implement accelerated cursor composition is to replace the cursor and warp it so that the replaced cursor is shown at the correct position on the guest display for relative pointer devices. Unfortunately, ui/cocoa cannot do the same because warping the cursor position interfers with the mouse input so it uses CALayer instead; although it is not specialized for cursor composition, it still can compose images with hardware acceleration. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- Changes in v3: - Incorporated changes from: "[PATCH v3 1/4] ui/cocoa: Typo fix in based-on patches" - Link to v2: https://lore.kernel.org/r/20240627-cursor-v2-0-c3cd3ee35616@daynix.com Changes in v2: - Incorporated changes from: https://lore.kernel.org/r/20240625134931.92279-2-phil@philjordan.eu ("[PATCH v2 1/2] ui/cocoa: Minor fixes to CALayer based cursors") - Added patch "ui/cocoa: Release CGColorSpace" - Added patch "ui/console: Convert mouse visibility parameter into bool" - Noted that the problem with warping is relevant only for relative pointer devices. - Link to v1: https://lore.kernel.org/r/20240318-cursor-v1-0-0bbe6c382217@daynix.com --- Akihiko Odaki (4): ui/cocoa: Release CGColorSpace ui/console: Convert mouse visibility parameter into bool ui/cocoa: Add cursor composition ui/console: Remove dpy_cursor_define_supported() meson.build | 3 +- include/ui/console.h | 5 +-- hw/display/ati.c | 2 +- hw/display/qxl-render.c | 4 -- hw/display/virtio-gpu.c | 3 +- hw/display/vmware_vga.c | 8 ++-- ui/console.c | 18 ++------- ui/dbus-listener.c | 2 +- ui/gtk.c | 2 +- ui/sdl2.c | 4 +- ui/spice-display.c | 11 ++--- ui/vnc.c | 2 +- ui/cocoa.m | 104 +++++++++++++++++++++++++++++++++++++++++++++++- 13 files changed, 126 insertions(+), 42 deletions(-) --- base-commit: 74abb45dac6979e7ff76172b7f0a24e869405184 change-id: 20240318-cursor-3491b1806582 Best regards,