From patchwork Mon Jul 15 22:12:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yichen Wang X-Patchwork-Id: 13733928 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61651C41513 for ; Mon, 15 Jul 2024 22:13:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTTwY-00051u-GE; Mon, 15 Jul 2024 18:13:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTTwT-0004zm-H6 for qemu-devel@nongnu.org; Mon, 15 Jul 2024 18:13:09 -0400 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTTwQ-0006Il-U1 for qemu-devel@nongnu.org; Mon, 15 Jul 2024 18:13:09 -0400 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6b77402d778so9749976d6.2 for ; Mon, 15 Jul 2024 15:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1721081580; x=1721686380; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PCQJ4sEoH6aDiRd4q2AhgK0kbrrvmoxsE8i+4zqYvUQ=; b=FWLda1DA09bbufa2FUjooyW+XXah3BNOEn+3g+xrA38Y5Hs3A12Ja9SHCmWC9L+AQ4 U6q8sNPY6QKxtfWbkXFyxsT2Y2RyD1pZXzSNL3FMlTTgehm+NSobnhOe/EmcXv8AJXvH L2u4xDVQdTXf2PbPRphIh7CarreCga/O+WmfBqkls9Ct++Z5rI0lot6WemxsBLlR4koB psZatH2DQOQ0+f6i49sgdmwHSr6PCUNVDNNlmtIFNGZzVps/jkxlvc0D6JEMt353dEfv nBGeyax79s6CjhMeDPSzy5CgELzTzKJ5jfu/GcE60WSlQ63IpjctuMlSgLCoN5FSnHTZ ZTYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721081580; x=1721686380; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PCQJ4sEoH6aDiRd4q2AhgK0kbrrvmoxsE8i+4zqYvUQ=; b=IpNgJY5kae13rwNvO5i3Qj6JH/7Iaj+5psMCFXgFEDrtJurkTGGpwtVDVqjB01bMJB wP8p+RXwMKDqRnl3TJ0J+W+y2bUVHzUB6gDN5qOKDQCRjy8agWiPIuPpuwFYZA+SJM9h 2C4V7EekZOznC35MqhB1RBdzWj0lan4Bwys48wDIbXqFRM453eVNAeouxn1D0fpb7VFF zvoVyiopkj83HKfZufm33//55FEpow47JFzhtY8y3AmoCIdTxPzWcetIFI4W5G6S2Ej7 FRrJZKH9PVSQerRpWKUDF47NOxuz7GJPUTElFOBU/V0TUU9me2Er287N/sptMR+LlQbm 14JQ== X-Forwarded-Encrypted: i=1; AJvYcCVeMt3DasAFz9FuxJHjEvc7CmWGtz0hvyKGdFvRpj1y2Vevx1mczBECs/1klaLGMf+Muf4x6T6KfYeo1YrHISzySIfcljc= X-Gm-Message-State: AOJu0YzBtgbz7tj22I/qDlv+Oicux87RUxfkMFLK0m5g4B7K4dScXFHt F/AuIzJ7qv8h7lYVe7IfAYiLNmyyivClWsngnQ0Cmekh8hjpwfABUX7uND7W20I= X-Google-Smtp-Source: AGHT+IF+Mc2Mso7goJ/sVpoyeWO5HaOt09Px87i+jzN5kA5nF6w0dL4p2VlXSfLIt9gjXkHwQq+HEw== X-Received: by 2002:a05:6214:2622:b0:6b5:3ca8:8b82 with SMTP id 6a1803df08f44-6b77f4e94c4mr5358956d6.18.1721081579669; Mon, 15 Jul 2024 15:12:59 -0700 (PDT) Received: from DY4X0N7X05.bytedance.net (ec2-52-8-182-0.us-west-1.compute.amazonaws.com. [52.8.182.0]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b76198aca3sm25398326d6.51.2024.07.15.15.12.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 15 Jul 2024 15:12:59 -0700 (PDT) From: Yichen Wang To: Peter Xu , Fabiano Rosas , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eric Blake , Markus Armbruster , Laurent Vivier , qemu-devel@nongnu.org Cc: "Hao Xiang" , "Liu, Yuan1" , "Zou, Nanhai" , "Ho-Ren (Jack) Chuang" , "Yichen Wang" Subject: [PATCH v6 0/5] Implement QATzip compression method Date: Mon, 15 Jul 2024 15:12:40 -0700 Message-Id: <20240715221245.12435-1-yichen.wang@bytedance.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::f32; envelope-from=yichen.wang@bytedance.com; helo=mail-qv1-xf32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v6: - Rebase changes on top of 4ea7e9cd882f1574c129d67431784fecc426d23b - Address comments, typos, and styling issues - Re-factor QAT setup()/cleanup() logic v5: - Rebase changes on top of 59084feb256c617063e0dbe7e64821ae8852d7cf - Add documentations about migration with qatzip accerlation - Remove multifd-qatzip-sw-fallback option v4: - Rebase changes on top of 1a2d52c7fcaeaaf4f2fe8d4d5183dccaeab67768 - Move the IOV initialization to qatzip implementation - Only use qatzip to compress normal pages v3: - Rebase changes on top of master - Merge two patches per Fabiano Rosas's comment - Add versions into comments and documentations v2: - Rebase changes on top of recent multifd code changes. - Use QATzip API 'qzMalloc' and 'qzFree' to allocate QAT buffers. - Remove parameter tuning and use QATzip's defaults for better performance. - Add parameter to enable QAT software fallback. v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-12/msg03761.html * Performance We present updated performance results. For circumstantial reasons, v1 presented performance on a low-bandwidth (1Gbps) network. Here, we present updated results with a similar setup as before but with two main differences: 1. Our machines have a ~50Gbps connection, tested using 'iperf3'. 2. We had a bug in our memory allocation causing us to only use ~1/2 of the VM's RAM. Now we properly allocate and fill nearly all of the VM's RAM. Thus, the test setup is as follows: We perform multifd live migration over TCP using a VM with 64GB memory. We prepare the machine's memory by powering it on, allocating a large amount of memory (60GB) as a single buffer, and filling the buffer with the repeated contents of the Silesia corpus[0]. This is in lieu of a more realistic memory snapshot, which proved troublesome to acquire. We analyze CPU usage by averaging the output of 'top' every second during migration. This is admittedly imprecise, but we feel that it accurately portrays the different degrees of CPU usage of varying compression methods. We present the latency, throughput, and CPU usage results for all of the compression methods, with varying numbers of multifd threads (4, 8, and 16). [0] The Silesia corpus can be accessed here: https://sun.aei.polsl.pl//~sdeor/index.php?page=silesia ** Results 4 multifd threads: |---------------|---------------|----------------|---------|---------| |method |time(sec) |throughput(mbps)|send cpu%|recv cpu%| |---------------|---------------|----------------|---------|---------| |qatzip | 23.13 | 8749.94 |117.50 |186.49 | |---------------|---------------|----------------|---------|---------| |zlib |254.35 | 771.87 |388.20 |144.40 | |---------------|---------------|----------------|---------|---------| |zstd | 54.52 | 3442.59 |414.59 |149.77 | |---------------|---------------|----------------|---------|---------| |none | 12.45 |43739.60 |159.71 |204.96 | |---------------|---------------|----------------|---------|---------| 8 multifd threads: |---------------|---------------|----------------|---------|---------| |method |time(sec) |throughput(mbps)|send cpu%|recv cpu%| |---------------|---------------|----------------|---------|---------| |qatzip | 16.91 |12306.52 |186.37 |391.84 | |---------------|---------------|----------------|---------|---------| |zlib |130.11 | 1508.89 |753.86 |289.35 | |---------------|---------------|----------------|---------|---------| |zstd | 27.57 | 6823.23 |786.83 |303.80 | |---------------|---------------|----------------|---------|---------| |none | 11.82 |46072.63 |163.74 |238.56 | |---------------|---------------|----------------|---------|---------| 16 multifd threads: |---------------|---------------|----------------|---------|---------| |method |time(sec) |throughput(mbps)|send cpu%|recv cpu%| |---------------|---------------|----------------|---------|---------| |qatzip |18.64 |11044.52 | 573.61 |437.65 | |---------------|---------------|----------------|---------|---------| |zlib |66.43 | 2955.79 |1469.68 |567.47 | |---------------|---------------|----------------|---------|---------| |zstd |14.17 |13290.66 |1504.08 |615.33 | |---------------|---------------|----------------|---------|---------| |none |16.82 |32363.26 | 180.74 |217.17 | |---------------|---------------|----------------|---------|---------| ** Observations - In general, not using compression outperforms using compression in a non-network-bound environment. - 'qatzip' outperforms other compression workers with 4 and 8 workers, achieving a ~91% latency reduction over 'zlib' with 4 workers, and a ~58% latency reduction over 'zstd' with 4 workers. - 'qatzip' maintains comparable performance with 'zstd' at 16 workers, showing a ~32% increase in latency. This performance difference becomes more noticeable with more workers, as CPU compression is highly parallelizable. - 'qatzip' compression uses considerably less CPU than other compression methods. At 8 workers, 'qatzip' demonstrates a ~75% reduction in compression CPU usage compared to 'zstd' and 'zlib'. - 'qatzip' decompression CPU usage is less impressive, and is even slightly worse than 'zstd' and 'zlib' CPU usage at 4 and 16 workers. Bryan Zhang (4): meson: Introduce 'qatzip' feature to the build system migration: Add migration parameters for QATzip migration: Introduce 'qatzip' compression method tests/migration: Add integration test for 'qatzip' compression method Yuan Liu (1): docs/migration: add qatzip compression feature docs/devel/migration/features.rst | 1 + docs/devel/migration/qatzip-compression.rst | 251 +++++++++++++ hw/core/qdev-properties-system.c | 2 +- meson.build | 10 + meson_options.txt | 2 + migration/meson.build | 1 + migration/migration-hmp-cmds.c | 4 + migration/multifd-qatzip.c | 382 ++++++++++++++++++++ migration/multifd.h | 5 +- migration/options.c | 34 ++ migration/options.h | 1 + qapi/migration.json | 21 ++ scripts/meson-buildoptions.sh | 3 + tests/qtest/meson.build | 4 + tests/qtest/migration-test.c | 31 ++ 15 files changed, 749 insertions(+), 3 deletions(-) create mode 100644 docs/devel/migration/qatzip-compression.rst create mode 100644 migration/multifd-qatzip.c