| Message ID | 20240716-pmu-v3-0-8c7c1858a227@daynix.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | target/arm/kvm: Report PMU unavailability | expand |
On Tue, 16 Jul 2024 at 13:50, Akihiko Odaki <akihiko.odaki@daynix.com> wrote: > > target/arm/kvm.c checked PMU availability but claimed PMU is > available even if it is not. In fact, Asahi Linux supports KVM but lacks > PMU support. Only advertise PMU availability only when it is really > available. > > Fixes: dc40d45ebd8e ("target/arm/kvm: Move kvm_arm_get_host_cpu_features and unexport") > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > --- > Changes in v3: > - Dropped patch "target/arm: Do not allow setting 'pmu' for hvf". > - Dropped patch "target/arm: Allow setting 'pmu' only for host and max". > - Dropped patch "target/arm/kvm: Report PMU unavailability". > - Added patch "target/arm/kvm: Fix PMU feature bit early". > - Added patch "hvf: arm: Do not advance PC when raising an exception". > - Added patch "hvf: arm: Properly disable PMU". > - Changed to check for Armv8 before adding PMU property. > - Link to v2: https://lore.kernel.org/r/20240716-pmu-v2-0-f3e3e4b2d3d5@daynix.com > > Changes in v2: > - Restricted writes to 'pmu' to host and max. > - Prohibited writes to 'pmu' for hvf. > - Link to v1: https://lore.kernel.org/r/20240629-pmu-v1-0-7269123b88a4@daynix.com > > --- > Akihiko Odaki (5): > tests/arm-cpu-features: Do not assume PMU availability > target/arm/kvm: Fix PMU feature bit early > target/arm: Always add pmu property for Armv8 > hvf: arm: Do not advance PC when raising an exception > hvf: arm: Properly disable PMU Hi; I've left reviews for some of these patches. I'm going to apply "hvf: arm: Do not advance PC when raising an exception" to my target-arm queue since I'm about to do a pullreq for 9.1 softfreeze. thanks -- PMM
On Thu, 18 Jul 2024 at 13:14, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Tue, 16 Jul 2024 at 13:50, Akihiko Odaki <akihiko.odaki@daynix.com> wrote: > > > > target/arm/kvm.c checked PMU availability but claimed PMU is > > available even if it is not. In fact, Asahi Linux supports KVM but lacks > > PMU support. Only advertise PMU availability only when it is really > > available. > > > > Fixes: dc40d45ebd8e ("target/arm/kvm: Move kvm_arm_get_host_cpu_features and unexport") > > > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > > --- > > Changes in v3: > > - Dropped patch "target/arm: Do not allow setting 'pmu' for hvf". > > - Dropped patch "target/arm: Allow setting 'pmu' only for host and max". > > - Dropped patch "target/arm/kvm: Report PMU unavailability". > > - Added patch "target/arm/kvm: Fix PMU feature bit early". > > - Added patch "hvf: arm: Do not advance PC when raising an exception". > > - Added patch "hvf: arm: Properly disable PMU". > > - Changed to check for Armv8 before adding PMU property. > > - Link to v2: https://lore.kernel.org/r/20240716-pmu-v2-0-f3e3e4b2d3d5@daynix.com > > > > Changes in v2: > > - Restricted writes to 'pmu' to host and max. > > - Prohibited writes to 'pmu' for hvf. > > - Link to v1: https://lore.kernel.org/r/20240629-pmu-v1-0-7269123b88a4@daynix.com > > > > --- > > Akihiko Odaki (5): > > tests/arm-cpu-features: Do not assume PMU availability > > target/arm/kvm: Fix PMU feature bit early > > target/arm: Always add pmu property for Armv8 > > hvf: arm: Do not advance PC when raising an exception > > hvf: arm: Properly disable PMU > > Hi; I've left reviews for some of these patches. I'm going to > apply "hvf: arm: Do not advance PC when raising an exception" > to my target-arm queue since I'm about to do a pullreq for > 9.1 softfreeze. ...and I'll take patch 1 ("tests/arm-cpu-features: Do not assume PMU availability") too, since it's been reviewed. -- PMM
target/arm/kvm.c checked PMU availability but claimed PMU is available even if it is not. In fact, Asahi Linux supports KVM but lacks PMU support. Only advertise PMU availability only when it is really available. Fixes: dc40d45ebd8e ("target/arm/kvm: Move kvm_arm_get_host_cpu_features and unexport") Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- Changes in v3: - Dropped patch "target/arm: Do not allow setting 'pmu' for hvf". - Dropped patch "target/arm: Allow setting 'pmu' only for host and max". - Dropped patch "target/arm/kvm: Report PMU unavailability". - Added patch "target/arm/kvm: Fix PMU feature bit early". - Added patch "hvf: arm: Do not advance PC when raising an exception". - Added patch "hvf: arm: Properly disable PMU". - Changed to check for Armv8 before adding PMU property. - Link to v2: https://lore.kernel.org/r/20240716-pmu-v2-0-f3e3e4b2d3d5@daynix.com Changes in v2: - Restricted writes to 'pmu' to host and max. - Prohibited writes to 'pmu' for hvf. - Link to v1: https://lore.kernel.org/r/20240629-pmu-v1-0-7269123b88a4@daynix.com --- Akihiko Odaki (5): tests/arm-cpu-features: Do not assume PMU availability target/arm/kvm: Fix PMU feature bit early target/arm: Always add pmu property for Armv8 hvf: arm: Do not advance PC when raising an exception hvf: arm: Properly disable PMU target/arm/cpu.c | 3 +- target/arm/hvf/hvf.c | 318 +++++++++++++++++++++-------------------- target/arm/kvm.c | 7 +- tests/qtest/arm-cpu-features.c | 13 +- 4 files changed, 175 insertions(+), 166 deletions(-) --- base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6 change-id: 20240629-pmu-ad5f67e2c5d0 Best regards,