From patchwork Tue Jul 16 16:10:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Liu X-Patchwork-Id: 13734661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B801C3DA49 for ; Tue, 16 Jul 2024 15:56:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTkWk-0000fP-CH; Tue, 16 Jul 2024 11:55:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTkWN-000065-8j for qemu-devel@nongnu.org; Tue, 16 Jul 2024 11:55:24 -0400 Received: from mgamail.intel.com ([192.198.163.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTkWH-0007Rv-Tf for qemu-devel@nongnu.org; Tue, 16 Jul 2024 11:55:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721145314; x=1752681314; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tpsLMKJIQFAky+/kJ60UZVyG/3DdjHMTPZcVXZFK/To=; b=l63A95u0SzgjmZmAOGvWHNdk+lFf8R24+BQygEy6L01AW9F+WCsbA4dj 2zYSeHfCAgAtBUUqi0XhcqBZTVnzf3BXbe+9AL2FmUJ7KWsEKPpyve6vM Y6MpsrzbtsTA2VLeuFh6xl9H99e1mmn3Mff/q+WEqIMa3evn1uO+7nd5C mWK9oIX/wNKTfJjkawYLBl/5efe0clDwWqAqik6P06ZAgYybWOuBfcsuy fpBQKUpVytyVNsS5gkwpmfTGwg3rVWlRFRa2lcJ9KWpolgxh9exu+yH65 Z0y1gCmpQVgPeic2pIdfS4mY1mndLW8D85ALgLWSTmqKmTj7JOhH2Mv5D g==; X-CSE-ConnectionGUID: GTpenIX2RnGJPq8XGFITww== X-CSE-MsgGUID: PoKjGV3XTM+lzme1mSMuQQ== X-IronPort-AV: E=McAfee;i="6700,10204,11135"; a="18743668" X-IronPort-AV: E=Sophos;i="6.09,212,1716274800"; d="scan'208";a="18743668" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2024 08:54:46 -0700 X-CSE-ConnectionGUID: 7RqqBhFbRve3yyEmcDLvqg== X-CSE-MsgGUID: qmpv3ti6TzalfhsW7l2GoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,212,1716274800"; d="scan'208";a="50788236" Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by orviesa008.jf.intel.com with ESMTP; 16 Jul 2024 08:54:43 -0700 From: Zhao Liu To: Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcel Apfelbaum , Marcelo Tosatti Cc: Xiaoyao Li , Pankaj Gupta , Zide Chen , qemu-devel@nongnu.org, kvm@vger.kernel.org, Zhao Liu Subject: [PATCH v4 0/9] target/i386: Misc cleanup on KVM PV defs, outdated comments and error handling Date: Wed, 17 Jul 2024 00:10:06 +0800 Message-Id: <20240716161015.263031-1-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=192.198.163.15; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, This is my v4 cleanup series. Compared with v3 [1], * Returned kvm_vm_ioctl() directly in kvm_install_msr_filters(). * Added a patch (patch 9) to clean up ARRAY_SIZE(msr_handlers). Background and Introduction =========================== This series picks cleanup from my previous kvmclock [2] (as other renaming attempts were temporarily put on hold). In addition, this series also include the cleanup on a historically workaround, recent comment of coco interface [3] and error handling corner cases in kvm_arch_init(). Avoiding the fragmentation of these misc cleanups, I consolidated them all in one series and was able to tackle them in one go! [1]: https://lore.kernel.org/qemu-devel/20240715044955.3954304-1-zhao1.liu@intel.com/T/ [2]: https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1.liu@linux.intel.com/ [3]: https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc94ae@intel.com/ Thanks and Best Regards, Zhao --- Zhao Liu (9): target/i386/kvm: Add feature bit definitions for KVM CPUID target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and MSR_KVM_SYSTEM_TIME definitions target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled target/i386/kvm: Save/load MSRs of kvmclock2 (KVM_FEATURE_CLOCKSOURCE2) target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo target/i386/confidential-guest: Fix comment of x86_confidential_guest_kvm_type() target/i386/kvm: Clean up return values of MSR filter related functions target/i386/kvm: Clean up error handling in kvm_arch_init() target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with KVM_MSR_FILTER_MAX_RANGES hw/i386/kvm/clock.c | 5 +- target/i386/confidential-guest.h | 2 +- target/i386/cpu.h | 25 +++++++ target/i386/kvm/kvm.c | 113 +++++++++++++++++-------------- target/i386/kvm/kvm_i386.h | 4 +- 5 files changed, 92 insertions(+), 57 deletions(-)