mbox series

[0/2] Don't initialize HOST_IOMMU_DEVICE with mdev

Message ID 20240722070713.1342711-1-zhenzhong.duan@intel.com (mailing list archive)
Headers show
Series Don't initialize HOST_IOMMU_DEVICE with mdev | expand

Message

Duan, Zhenzhong July 22, 2024, 7:07 a.m. UTC
This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE.
Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO.

I thought ap/ccw are all mdev type and need a fix.

This series depends on a patch from Joao which fixes the same for vfio-pci.
See https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg04612.html

Not tested due to no ap/ccw environment. But build test pass.

Thanks
Zhenzhong

Zhenzhong Duan (2):
  vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
  vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev

 hw/vfio/ap.c  | 3 +++
 hw/vfio/ccw.c | 3 +++
 2 files changed, 6 insertions(+)

Comments

Eric Auger July 22, 2024, 9:31 a.m. UTC | #1
Hi Zhenzhong,

On 7/22/24 09:07, Zhenzhong Duan wrote:
> This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE.
> Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO.
>
> I thought ap/ccw are all mdev type and need a fix.
>
> This series depends on a patch from Joao which fixes the same for vfio-pci.
> See https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg04612.html
>
> Not tested due to no ap/ccw environment. But build test pass.
>
> Thanks
> Zhenzhong
>
> Zhenzhong Duan (2):
>   vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
>   vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev
For the series
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Eric

>
>  hw/vfio/ap.c  | 3 +++
>  hw/vfio/ccw.c | 3 +++
>  2 files changed, 6 insertions(+)
>
Cédric Le Goater July 22, 2024, 10:02 a.m. UTC | #2
On 7/22/24 09:07, Zhenzhong Duan wrote:
> This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE.
> Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO.
> 
> I thought ap/ccw are all mdev type and need a fix.
> 
> This series depends on a patch from Joao which fixes the same for vfio-pci.
> See https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg04612.html
> 
> Not tested due to no ap/ccw environment. But build test pass.
> 
> Thanks
> Zhenzhong
> 
> Zhenzhong Duan (2):
>    vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
>    vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev
> 
>   hw/vfio/ap.c  | 3 +++
>   hw/vfio/ccw.c | 3 +++
>   2 files changed, 6 insertions(+)
> 

I have queued this series and the first 2 patches of "[v5] hw/vfio: IOMMUFD
Dirty Tracking" :

   https://lore.kernel.org/all/20240719120501.81279-1-joao.m.martins@oracle.com/

I am trying to estimate now if the above could be fully merge for 9.1.

Thanks,

C.
Cédric Le Goater July 22, 2024, 1:50 p.m. UTC | #3
On 7/22/24 09:07, Zhenzhong Duan wrote:
> This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE.
> Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO.
> 
> I thought ap/ccw are all mdev type and need a fix.
> 
> This series depends on a patch from Joao which fixes the same for vfio-pci.
> See https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg04612.html
> 
> Not tested due to no ap/ccw environment. But build test pass.
> 
> Thanks
> Zhenzhong
> 
> Zhenzhong Duan (2):
>    vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
>    vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev
> 
>   hw/vfio/ap.c  | 3 +++
>   hw/vfio/ccw.c | 3 +++
>   2 files changed, 6 insertions(+)
> 


Applied to vfio-next.

Thanks,

C.