[v2,0/7] util/fifo8: Rework fifo8_pop_buf()

Message

Philippe Mathieu-Daudé July 22, 2024, 4:07 p.m. UTC

Rename current fifo8_pop_buf() as fifo8_pop_constbuf()
and expose ESP's fifo8_pop_buf() which takes care of
wrapped FIFO buffer.

Supersedes: <[e-mail]>
  util/fifo8: Introduce fifo8_change_capacity()

Philippe Mathieu-Daudé (7):
  chardev/char-fe: Document returned value on error
  util/fifo8: Fix style
  util/fifo8: Use fifo8_reset() in fifo8_create()
  util/fifo8: Rename fifo8_peek_buf() -> fifo8_peek_constbuf()
  util/fifo8: Rename fifo8_pop_buf() -> fifo8_pop_constbuf()
  util/fifo8: Expose fifo8_pop_buf()
  util/fifo8: Introduce fifo8_discard()

 include/chardev/char-fe.h |  3 +++
 include/qemu/fifo8.h      | 50 ++++++++++++++++++++++++---------------
 chardev/msmouse.c         |  2 +-
 hw/char/goldfish_tty.c    |  4 ++--
 hw/net/allwinner_emac.c   |  2 +-
 hw/scsi/esp.c             | 38 ++++-------------------------
 ui/console-vc.c           |  2 +-
 ui/gtk.c                  |  2 +-
 util/fifo8.c              | 48 +++++++++++++++++++++++++++++++------
 9 files changed, 85 insertions(+), 66 deletions(-)

Comments

Philippe Mathieu-Daudé July 23, 2024, 6:02 p.m. UTC | #1

On 22/7/24 18:07, Philippe Mathieu-Daudé wrote:
> Rename current fifo8_pop_buf() as fifo8_pop_constbuf()
> and expose ESP's fifo8_pop_buf() which takes care of
> wrapped FIFO buffer.
> 
> Supersedes: <[e-mail]>
>    util/fifo8: Introduce fifo8_change_capacity()
> 
> Philippe Mathieu-Daudé (7):
>    chardev/char-fe: Document returned value on error
>    util/fifo8: Fix style
>    util/fifo8: Use fifo8_reset() in fifo8_create()
>    util/fifo8: Rename fifo8_peek_buf() -> fifo8_peek_constbuf()
>    util/fifo8: Rename fifo8_pop_buf() -> fifo8_pop_constbuf()
>    util/fifo8: Expose fifo8_pop_buf()
>    util/fifo8: Introduce fifo8_discard()

Series queued, thanks.