From patchwork Fri Aug 2 07:24:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: LIU Zhiwei X-Patchwork-Id: 13751182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7FF8C3DA7F for ; Fri, 2 Aug 2024 07:26:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZmf4-0005jH-O2; Fri, 02 Aug 2024 03:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZmf2-0005iK-HQ; Fri, 02 Aug 2024 03:25:13 -0400 Received: from out30-100.freemail.mail.aliyun.com ([115.124.30.100]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZmez-0002aH-Ns; Fri, 02 Aug 2024 03:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1722583500; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; bh=9cel5httlyghO30gyy6Rx79KW6bl+MzQvrEr35l8arE=; b=V6KE2FhCVxwOWePJYKrRqBaQvQLzOHOTehNIaKroM4IeGsUlJFI0PyQ6oC7te5BxLkoJljA/++mn58UXCi/uuLN5KTx897OoA0z5eDpujY05UDoz5RbszcurJuS0/anhWH+YB3ywMRoB5W9xSBMXc7OKQOHAWbXfoobTO6oCMFs= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R181e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037067111; MF=zhiwei_liu@linux.alibaba.com; NM=1; PH=DS; RN=9; SR=0; TI=SMTPD_---0WBwcv.e_1722583498; Received: from L-PF1D6DP4-1208.hz.ali.com(mailfrom:zhiwei_liu@linux.alibaba.com fp:SMTPD_---0WBwcv.e_1722583498) by smtp.aliyun-inc.com; Fri, 02 Aug 2024 15:24:59 +0800 From: LIU Zhiwei To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, palmer@dabbelt.com, alistair.francis@wdc.com, dbarboza@ventanamicro.com, liwei1518@gmail.com, bmeng.cn@gmail.com, zhiwei_liu@linux.alibaba.com, richard.henderson@linaro.org Subject: [PATCH v3 0/3] target/riscv: Remove redundant insn length check for zama16b Date: Fri, 2 Aug 2024 15:24:14 +0800 Message-Id: <20240802072417.659-1-zhiwei_liu@linux.alibaba.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Received-SPF: pass client-ip=115.124.30.100; envelope-from=zhiwei_liu@linux.alibaba.com; helo=out30-100.freemail.mail.aliyun.com X-Spam_score_int: -174 X-Spam_score: -17.5 X-Spam_bar: ----------------- X-Spam_report: (-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org In this patch set, we remove the redundant insn length check for zama16b as the specification clarified that zama16b applies to compressed encodings[1]. Richard points out we should obey the MXLEN requirement for F/D/Q loads or stores, so we add this constraint for trans_fld/fsd. I notice that we have a too strict aligment implementation for fld/fsd when xlen < 64. It will hide some problems. So relex it from MO_ATOM_IFALIGN to MO_ATOM_NONE. [1]: https://github.com/riscv/riscv-isa-manual/pull/1557 v3<-v2: 1. Using get_xl_max instead of ctx->misa_mxl_max as documentation. 2. Fix not clean split in patch 1. 3. Explicitly specified aligment for fld/fsd under all cases. v2<-v1: 1. Add mxlen check for fld when applies zama16b. 2. Relax fld/fsd alignment for MO_ATOM_IFALIGN to MO_ATOM_NONE. LIU Zhiwei (3): target/riscv: Remove redundant insn length check for zama16b target/riscv: Add MXLEN check for F/D/Q applies to zama16b target/riscv: Relax fld alignment requirement target/riscv/insn_trans/trans_rvd.c.inc | 18 ++++++++++++++++-- target/riscv/insn_trans/trans_rvf.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvi.c.inc | 4 ++-- 3 files changed, 20 insertions(+), 6 deletions(-)