mbox series

[v2,0/2] target/ppc: Make divd[u] handler method decodetree compatible

Message ID 20240812085841.1583-1-iii@linux.ibm.com (mailing list archive)
Headers show
Series target/ppc: Make divd[u] handler method decodetree compatible | expand

Message

Ilya Leoshkevich Aug. 12, 2024, 8:53 a.m. UTC 
v1: https://lore.kernel.org/qemu-devel/20240731100953.14950-1-iii@linux.ibm.com/
v1 -> v2: Add R-bs and a targeted divd[u] patch.

Hi,

This series contains two fixes for the same issue: divd[u] touching
uninitialized ctx->opcode.

Patch 1 is a catch-all solution for all issues in this class. IMHO
it's worth having something like this until the legacy decoder is
fully eliminated.

Patch 2 is a targeted fix for divd[u] only.

Best regards,
Ilya

Ilya Leoshkevich (2):
  target/ppc: Set ctx->opcode for decode_insn32()
  target/ppc: Make divd[u] handler method decodetree compatible

 target/ppc/translate.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Ilya Leoshkevich Sept. 18, 2024, 9:56 a.m. UTC | #1 
On Mon, 2024-08-12 at 10:53 +0200, Ilya Leoshkevich wrote:
> v1:
> https://lore.kernel.org/qemu-devel/20240731100953.14950-1-iii@linux.ibm.com/
> v1 -> v2: Add R-bs and a targeted divd[u] patch.
> 
> Hi,
> 
> This series contains two fixes for the same issue: divd[u] touching
> uninitialized ctx->opcode.
> 
> Patch 1 is a catch-all solution for all issues in this class. IMHO
> it's worth having something like this until the legacy decoder is
> fully eliminated.
> 
> Patch 2 is a targeted fix for divd[u] only.
> 
> Best regards,
> Ilya
> 
> Ilya Leoshkevich (2):
>   target/ppc: Set ctx->opcode for decode_insn32()
>   target/ppc: Make divd[u] handler method decodetree compatible
> 
>  target/ppc/translate.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Ping.
Nicholas Piggin Oct. 8, 2024, 5:16 a.m. UTC | #2 
On Wed Sep 18, 2024 at 7:56 PM AEST, Ilya Leoshkevich wrote:
> On Mon, 2024-08-12 at 10:53 +0200, Ilya Leoshkevich wrote:
> > v1:
> > https://lore.kernel.org/qemu-devel/20240731100953.14950-1-iii@linux.ibm.com/
> > v1 -> v2: Add R-bs and a targeted divd[u] patch.
> > 
> > Hi,
> > 
> > This series contains two fixes for the same issue: divd[u] touching
> > uninitialized ctx->opcode.
> > 
> > Patch 1 is a catch-all solution for all issues in this class. IMHO
> > it's worth having something like this until the legacy decoder is
> > fully eliminated.
> > 
> > Patch 2 is a targeted fix for divd[u] only.
> > 
> > Best regards,
> > Ilya
> > 
> > Ilya Leoshkevich (2):
> >   target/ppc: Set ctx->opcode for decode_insn32()
> >   target/ppc: Make divd[u] handler method decodetree compatible
> > 
> >  target/ppc/translate.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
>
> Ping.

Hey Ilya,

Sorry for the late reply, had some time off and taken me a while
to get back to it.

Yeah this is a good fix, thank you. I have queued it.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

Thanks,
Nick