[v4,0/2] RISC-V: Add preliminary textra trigger CSR functions

Message

Alvin Che-Chia Chang(張哲嘉) Aug. 26, 2024, 2:46 a.m. UTC

According to RISC-V Debug specification, the optional textra32 and textra64
trigger CSRs can be used to configure additional matching conditions for the
triggers.

This series support to write MHVALUE and MHSELECT fields into textra32 and
textra64 trigger CSRs. Besides, the additional matching condition between
textra.MHVALUE and mcontext CSR is also implemented.

Changes from v3:
- Simplify the comparison between mcontext and textra.MHVALUE

Changes from v2:
- Remove redundant log

Changes from v1:
- Log that mhselect only supports 0 or 4 for now
- Simplify writing of tdata3

Alvin Chang (2):
  target/riscv: Preliminary textra trigger CSR writting support
  target/riscv: Add textra matching condition for the triggers

 target/riscv/cpu_bits.h |  10 ++++
 target/riscv/debug.c    | 114 +++++++++++++++++++++++++++++++++++++---
 target/riscv/debug.h    |   3 ++
 3 files changed, 120 insertions(+), 7 deletions(-)

Comments

Alistair Francis Sept. 6, 2024, 5:20 a.m. UTC | #1

On Mon, Aug 26, 2024 at 12:48 PM Alvin Chang via <[e-mail]> wrote:
>
> According to RISC-V Debug specification, the optional textra32 and textra64
> trigger CSRs can be used to configure additional matching conditions for the
> triggers.
>
> This series support to write MHVALUE and MHSELECT fields into textra32 and
> textra64 trigger CSRs. Besides, the additional matching condition between
> textra.MHVALUE and mcontext CSR is also implemented.
>
> Changes from v3:
> - Simplify the comparison between mcontext and textra.MHVALUE
>
> Changes from v2:
> - Remove redundant log
>
> Changes from v1:
> - Log that mhselect only supports 0 or 4 for now
> - Simplify writing of tdata3
>
> Alvin Chang (2):
>   target/riscv: Preliminary textra trigger CSR writting support
>   target/riscv: Add textra matching condition for the triggers

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  target/riscv/cpu_bits.h |  10 ++++
>  target/riscv/debug.c    | 114 +++++++++++++++++++++++++++++++++++++---
>  target/riscv/debug.h    |   3 ++
>  3 files changed, 120 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>
>