From patchwork Wed Sep 4 10:37:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juraj Marcin X-Patchwork-Id: 13790427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C61BCA0ED3 for ; Wed, 4 Sep 2024 10:44:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slnUk-0000wh-Sf; Wed, 04 Sep 2024 06:44:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slnUc-0000Ue-BM for qemu-devel@nongnu.org; Wed, 04 Sep 2024 06:44:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slnUa-0001pV-Bl for qemu-devel@nongnu.org; Wed, 04 Sep 2024 06:44:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725446643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6HgcdvGspNzOVc7Q5mw90hMWp2IUOCxo3jYRCQQgg08=; b=TDebQe699/ajbrSmqznCviVKrFaD0UGgVl6nZE7SG4Ii0Z9i9OaIFZfhoShNuOfjOzojwa V5mQjv4vRCCkDxSdOuTV2qDoCf9OPnsKb9KhkyY/knqIP/t/Avp2ZKNaaqEjqcs0+GkoGr WgKi/RTNdTEHtmUD7ZUeqrtFHrH7yps= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-_OWnXxw4Mz-5G1c6gIXYQQ-1; Wed, 04 Sep 2024 06:37:41 -0400 X-MC-Unique: _OWnXxw4Mz-5G1c6gIXYQQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EDEAE19560AB; Wed, 4 Sep 2024 10:37:39 +0000 (UTC) Received: from rh-jmarcin.redhat.com (unknown [10.45.225.176]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DF140195605A; Wed, 4 Sep 2024 10:37:37 +0000 (UTC) From: Juraj Marcin To: qemu-devel@nongnu.org Cc: Juraj Marcin , David Hildenbrand , Peter Maydell Subject: [PATCH v3 0/4] virtio-mem: Implement support for suspend+wake-up with plugged memory Date: Wed, 4 Sep 2024 12:37:11 +0200 Message-ID: <20240904103722.946194-1-jmarcin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.129.124; envelope-from=jmarcin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Currently, the virtio-mem device would unplug all the memory with any reset request, including when the machine wakes up from a suspended state (deep sleep). This would lead to a loss of the contents of the guest memory and therefore is disabled by the virtio-mem Linux Kernel driver unless the VIRTIO_MEM_F_PERSISTENT_SUSPEND virtio feature is exposed. [1] To make deep sleep with virtio-mem possible, we need to differentiate cold start reset from wake-up reset. The first patch updates qemu_system_reset() and MachineClass children to accept ResetType instead of ShutdownCause, which then could be passed down the device tree. The second patch then introduces the new reset type for the wake-up event and updates the i386 wake-up method (only architecture using the explicit wake-up method). The third patch replaces LegacyReset with the Resettable interface in virtio-mem, so the memory device can access the reset type in the hold phase. The last patch of the series implements the final support in the hold phase of the virtio-mem reset callback and exposes VIRTIO_MEM_F_PERSISTENT_SUSPEND to the kernel. [1]: https://lore.kernel.org/all/20240318120645.105664-1-david@redhat.com/ v3: - Updated RESET_TYPE_WAKEUP documentation so it is more clear when reset could occur and when reset type should be used, thanks to Peter and David for feedback v2: - Removed unnecessary include directive changes - Updated RESET_TYPE_WAKEUP documentation - Removed unnecessary interface from VirtIOMEMClass type info Juraj Marcin (4): reset: Use ResetType for qemu_devices_reset() and MachineClass::reset() reset: Add RESET_TYPE_WAKEUP virtio-mem: Use new Resettable framework instead of LegacyReset virtio-mem: Add support for suspend+wake-up with plugged memory docs/devel/reset.rst | 11 ++++++++ hw/arm/aspeed.c | 4 +-- hw/arm/mps2-tz.c | 4 +-- hw/core/reset.c | 5 +--- hw/hppa/machine.c | 4 +-- hw/i386/microvm.c | 4 +-- hw/i386/pc.c | 6 ++--- hw/ppc/pegasos2.c | 4 +-- hw/ppc/pnv.c | 4 +-- hw/ppc/spapr.c | 6 ++--- hw/s390x/s390-virtio-ccw.c | 4 +-- hw/virtio/virtio-mem.c | 48 ++++++++++++++++++++++++---------- hw/virtio/virtio-qmp.c | 3 +++ include/hw/boards.h | 3 ++- include/hw/resettable.h | 2 ++ include/hw/virtio/virtio-mem.h | 4 +++ include/sysemu/reset.h | 5 ++-- system/runstate.c | 13 +++++++-- 18 files changed, 91 insertions(+), 43 deletions(-)