From patchwork Tue Oct 8 12:50:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 13826434 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 950DACEF16B for ; Tue, 8 Oct 2024 12:51:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sy9g2-0007On-Rb; Tue, 08 Oct 2024 08:51:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy9fp-0007Nk-7Z for qemu-devel@nongnu.org; Tue, 08 Oct 2024 08:50:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy9fl-0002Mp-Q5 for qemu-devel@nongnu.org; Tue, 08 Oct 2024 08:50:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728391839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gbHOrj9ix2EU4/PmK12j53b4sbI1WvMKNhJdsX1A6TU=; b=TRY9Ki11Dd9XBrFMSF/eHkyWeTDMjH5r8JbQ8iLIc2xyw6GaL3JokBwdUbRNLb72h63vIh gfHe+2umO001l1yFuKkmZJOmJ9Fdw93rvLo6Lo8IF7oKWuML3S417WGNsgI0JPG5Cq08JE xF8/b/oPSjlI4paEqvBUGdjpNQJ2dDM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-30KW47fnPLKqb47g1ouS4g-1; Tue, 08 Oct 2024 08:50:35 -0400 X-MC-Unique: 30KW47fnPLKqb47g1ouS4g-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B903A1979062; Tue, 8 Oct 2024 12:50:33 +0000 (UTC) Received: from localhost (unknown [10.39.208.19]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 130FB1956089; Tue, 8 Oct 2024 12:50:31 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Peter Maydell , Akihiko Odaki , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" , belmouss@redhat.com, =?utf-8?q?Danie?= =?utf-8?q?l_P=2E_Berrang=C3=A9?= , Thomas Huth , Paolo Bonzini , Gerd Hoffmann , Laurent Vivier Subject: [PATCH v2 00/19] UI-related fixes & shareable 2d memory with -display dbus Date: Tue, 8 Oct 2024 16:50:09 +0400 Message-ID: <20241008125028.1177932-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.151, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Marc-André Lureau Hi, This series adds Listener.Unix.Map interface to -display dbus, to allow shared memory for the display (similar to Listener.Win32.Map interface). While working on it, I collected a few fixes. I can re-send them in a different series or queue them once they are reviewed. thanks v2 (after Akhiko Odaki review): - rebased - introduce qemu_pixman_shareable, to reduce #ifdef usage - fixed bad mmap testing - fixed mingw cross-compilation Marc-André Lureau (19): hw/audio/hda: free timer on exit hw/audio/hda: fix memory leak on audio setup ui/dbus: fix leak on message filtering ui/win32: fix potential use-after-free with dbus shared memory ui/dbus: fix filtering all update messages ui/dbus: discard display messages on disable ui/dbus: discard pending CursorDefine on new one util/memfd: report potential errors on free ui/pixman: generalize shared_image_destroy ui/dbus: do not limit to one listener per connection / bus name ui/dbus: add trace for can_share_map ui/surface: allocate shared memory on !win32 meson: find_program('gdbus-codegen') directly ui/dbus: make Listener.Win32.Map win32-specific ui/dbus: add Listener.Unix.Map interface XML ui/dbus: implement Unix.Map virtio-gpu: allocate shareable 2d resources on !win32 ui: refactor using a common qemu_pixman_shareable tests: add basic -display dbus Map.Unix test meson.build | 2 +- include/hw/virtio/virtio-gpu.h | 4 +- include/ui/qemu-pixman.h | 24 +++++ include/ui/surface.h | 14 ++- hw/audio/hda-codec.c | 33 ++++--- hw/display/virtio-gpu.c | 69 ++++---------- tests/qtest/dbus-display-test.c | 72 ++++++++++++++- ui/console.c | 78 ++++++---------- ui/dbus-console.c | 23 +---- ui/dbus-listener.c | 159 ++++++++++++++++++++++++++++---- ui/qemu-pixman.c | 71 ++++++++++++++ util/memfd.c | 9 +- ui/dbus-display1.xml | 49 ++++++++++ ui/trace-events | 1 + 14 files changed, 440 insertions(+), 168 deletions(-) Reviewed-by: Akihiko Odaki