mbox series

[0/5] hw/acpi: Fixes + tests for ACPI Generic Port Affinity Struturs

Message ID 20241107123446.902801-1-Jonathan.Cameron@huawei.com (mailing list archive)
Headers show
Series hw/acpi: Fixes + tests for ACPI Generic Port Affinity Struturs | expand

Message

Jonathan Cameron Nov. 7, 2024, 12:34 p.m. UTC 
A couple of issues have been reported on this code that has been merged
for 9.2.

A) Missed a version number update in the qapi/qom.json docs when rebasing
   for 9.2.
B) A test failure on i686 (32bit) bios tables test for x86_64.

This second one was a refactoring mistake where visibility of the size
of an array of 8 characters had been replaced with a pointer which on 64
bit hosts is also 8 bytes, but not on 32 bits, leading to a miss-alignment
of the final structure in the table and a test failure. Fix by hard coding
the size as 8 given it is always this size for the relevant ACPI HIDs.

For completeness the tests are also included. Some reference tables
needed an update to incorporate other changes.

Jonathan Cameron (5):
  hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle()
  qapi/qom: Change Since entry for AcpiGenericPortProperties to 9.2
  bios-tables-test: Allow for new acpihmat-generic-x test data.
  bios-tables-test: Add complex SRAT / HMAT test for GI GP
  bios-tables-test: Add data for complex numa test (GI, GP etc)

 qapi/qom.json                                 |   2 +-
 hw/acpi/aml-build.c                           |   2 +-
 tests/qtest/bios-tables-test.c                |  97 ++++++++++++++++++
 .../data/acpi/x86/q35/APIC.acpihmat-generic-x | Bin 0 -> 136 bytes
 .../data/acpi/x86/q35/CEDT.acpihmat-generic-x | Bin 0 -> 68 bytes
 .../data/acpi/x86/q35/DSDT.acpihmat-generic-x | Bin 0 -> 12599 bytes
 .../data/acpi/x86/q35/HMAT.acpihmat-generic-x | Bin 0 -> 360 bytes
 .../data/acpi/x86/q35/SRAT.acpihmat-generic-x | Bin 0 -> 520 bytes
 8 files changed, 99 insertions(+), 2 deletions(-)
 create mode 100644 tests/data/acpi/x86/q35/APIC.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/HMAT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/SRAT.acpihmat-generic-x