mbox series

[0/4] hw/timer/hpet: Make fw_cfg state private to HPET class

Message ID 20241206191124.9195-1-philmd@linaro.org (mailing list archive)
Headers show
Series hw/timer/hpet: Make fw_cfg state private to HPET class | expand

Message

Philippe Mathieu-Daudé Dec. 6, 2024, 7:11 p.m. UTC
No need to have an external hpet_cfg[] array accessed
outside of hpet.c. Move it in the class state.

Philippe Mathieu-Daudé (4):
  hw/timer/hpet: Introduce hpet_add_fw_cfg_bytes()
  hw/timer/hpet: Reduce hpet_cfg[] scope
  hw/timer/hpet: Have hpet_find() return an Object
  hw/timer/hpet: Hold fw_cfg state within HPET class

 include/hw/timer/hpet.h | 20 +++-------------
 hw/i386/fw_cfg.c        |  5 ++--
 hw/timer/hpet.c         | 52 ++++++++++++++++++++++++++++++++++-------
 3 files changed, 49 insertions(+), 28 deletions(-)

Comments

Philippe Mathieu-Daudé Dec. 13, 2024, 11:21 a.m. UTC | #1
On 6/12/24 20:11, Philippe Mathieu-Daudé wrote:
> No need to have an external hpet_cfg[] array accessed
> outside of hpet.c. Move it in the class state.
> 
> Philippe Mathieu-Daudé (4):
>    hw/timer/hpet: Introduce hpet_add_fw_cfg_bytes()
>    hw/timer/hpet: Reduce hpet_cfg[] scope
>    hw/timer/hpet: Have hpet_find() return an Object
>    hw/timer/hpet: Hold fw_cfg state within HPET class

ping