[0/3] cpuhp: ensure that cpu hotremove works the 1st time

Message ID	20241210163945.3422623-1-imammedo@redhat.com (mailing list archive)
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Igor Mammedov <imammedo@redhat.com> To: qemu-devel@nongnu.org Cc: mst@redhat.com, imammedo@redhat.com, eric.mackay@oracle.com, anisinha@redhat.com Subject: [PATCH 0/3] cpuhp: ensure that cpu hotremove works the 1st time Date: Tue, 10 Dec 2024 17:39:42 +0100 Message-ID: <20241210163945.3422623-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.52, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	cpuhp: ensure that cpu hotremove works the 1st time \| expand [0/3] cpuhp: ensure that cpu hotremove works the 1st time [1/3] tests: acpi: whitelist expected blobs [2/3] cpuhp: make sure that remove events are handled within the same SCI [3/3] tests: acpi: update expected blobs

Message ID

20241210163945.3422623-1-imammedo@redhat.com (mailing list archive)

Headers

From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, imammedo@redhat.com, eric.mackay@oracle.com,
 anisinha@redhat.com
Subject: [PATCH 0/3] cpuhp: ensure that cpu hotremove works the 1st time
Date: Tue, 10 Dec 2024 17:39:42 +0100
Message-ID: <20241210163945.3422623-1-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=170.10.133.124;
 envelope-from=imammedo@redhat.com;
 helo=us-smtp-delivery-124.mimecast.com
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.52,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org

Series

cpuhp: ensure that cpu hotremove works the 1st time | expand

Message

Igor Mammedov Dec. 10, 2024, 4:39 p.m. UTC

CPU hotremove event is not delivered to OSPM if the CPU
has been hotplugged before OS has booted.
For details see [2/3].

Igor Mammedov (3):
  tests: acpi: whitelist expected blobs
  cpuhp: make sure that remove events are handled within the same SCI
  tests: acpi: update expected blobs

 hw/acpi/cpu.c                                 |  43 ++++++++++++++----
 tests/data/acpi/x86/pc/DSDT                   | Bin 8526 -> 8593 bytes
 tests/data/acpi/x86/pc/DSDT.acpierst          | Bin 8437 -> 8504 bytes
 tests/data/acpi/x86/pc/DSDT.acpihmat          | Bin 9851 -> 9918 bytes
 tests/data/acpi/x86/pc/DSDT.bridge            | Bin 15397 -> 15464 bytes
 tests/data/acpi/x86/pc/DSDT.cphp              | Bin 8990 -> 9057 bytes
 tests/data/acpi/x86/pc/DSDT.dimmpxm           | Bin 10180 -> 10247 bytes
 tests/data/acpi/x86/pc/DSDT.hpbridge          | Bin 8477 -> 8544 bytes
 tests/data/acpi/x86/pc/DSDT.hpbrroot          | Bin 5033 -> 5100 bytes
 tests/data/acpi/x86/pc/DSDT.ipmikcs           | Bin 8598 -> 8665 bytes
 tests/data/acpi/x86/pc/DSDT.memhp             | Bin 9885 -> 9952 bytes
 tests/data/acpi/x86/pc/DSDT.nohpet            | Bin 8384 -> 8451 bytes
 tests/data/acpi/x86/pc/DSDT.numamem           | Bin 8532 -> 8599 bytes
 tests/data/acpi/x86/pc/DSDT.roothp            | Bin 12319 -> 12386 bytes
 tests/data/acpi/x86/q35/DSDT                  | Bin 8355 -> 8422 bytes
 tests/data/acpi/x86/q35/DSDT.acpierst         | Bin 8372 -> 8439 bytes
 tests/data/acpi/x86/q35/DSDT.acpihmat         | Bin 9680 -> 9747 bytes
 .../data/acpi/x86/q35/DSDT.acpihmat-generic-x | Bin 12565 -> 12632 bytes
 .../acpi/x86/q35/DSDT.acpihmat-noinitiator    | Bin 8634 -> 8701 bytes
 tests/data/acpi/x86/q35/DSDT.applesmc         | Bin 8401 -> 8468 bytes
 tests/data/acpi/x86/q35/DSDT.bridge           | Bin 11968 -> 12035 bytes
 tests/data/acpi/x86/q35/DSDT.core-count       | Bin 12913 -> 12980 bytes
 tests/data/acpi/x86/q35/DSDT.core-count2      | Bin 33770 -> 33837 bytes
 tests/data/acpi/x86/q35/DSDT.cphp             | Bin 8819 -> 8886 bytes
 tests/data/acpi/x86/q35/DSDT.cxl              | Bin 13146 -> 13213 bytes
 tests/data/acpi/x86/q35/DSDT.dimmpxm          | Bin 10009 -> 10076 bytes
 tests/data/acpi/x86/q35/DSDT.ipmibt           | Bin 8430 -> 8497 bytes
 tests/data/acpi/x86/q35/DSDT.ipmismbus        | Bin 8443 -> 8510 bytes
 tests/data/acpi/x86/q35/DSDT.ivrs             | Bin 8372 -> 8439 bytes
 tests/data/acpi/x86/q35/DSDT.memhp            | Bin 9714 -> 9781 bytes
 tests/data/acpi/x86/q35/DSDT.mmio64           | Bin 9485 -> 9552 bytes
 tests/data/acpi/x86/q35/DSDT.multi-bridge     | Bin 13208 -> 13275 bytes
 tests/data/acpi/x86/q35/DSDT.noacpihp         | Bin 8235 -> 8302 bytes
 tests/data/acpi/x86/q35/DSDT.nohpet           | Bin 8213 -> 8280 bytes
 tests/data/acpi/x86/q35/DSDT.numamem          | Bin 8361 -> 8428 bytes
 tests/data/acpi/x86/q35/DSDT.pvpanic-isa      | Bin 8456 -> 8523 bytes
 tests/data/acpi/x86/q35/DSDT.thread-count     | Bin 12913 -> 12980 bytes
 tests/data/acpi/x86/q35/DSDT.thread-count2    | Bin 33770 -> 33837 bytes
 tests/data/acpi/x86/q35/DSDT.tis.tpm12        | Bin 8961 -> 9028 bytes
 tests/data/acpi/x86/q35/DSDT.tis.tpm2         | Bin 8987 -> 9054 bytes
 tests/data/acpi/x86/q35/DSDT.type4-count      | Bin 18589 -> 18656 bytes
 tests/data/acpi/x86/q35/DSDT.viot             | Bin 14612 -> 14679 bytes
 tests/data/acpi/x86/q35/DSDT.xapic            | Bin 35718 -> 35785 bytes
 43 files changed, 34 insertions(+), 9 deletions(-)

Comments

Eric Mackay Dec. 10, 2024, 9:18 p.m. UTC | #1

I tested your patch series, and I can confirm it fixes our bug repro case (not involving the guest kernel).
Thank you

On Tue, 10 Dec 2024 17:39:42 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> CPU hotremove event is not delivered to OSPM if the CPU
> has been hotplugged before OS has booted.
> For details see [2/3].
> 
> Igor Mammedov (3):
>   tests: acpi: whitelist expected blobs
>   cpuhp: make sure that remove events are handled within the same SCI
>   tests: acpi: update expected blobs
> 
>  hw/acpi/cpu.c                                 |  43 ++++++++++++++----
>  tests/data/acpi/x86/pc/DSDT                   | Bin 8526 -> 8593 bytes
>  tests/data/acpi/x86/pc/DSDT.acpierst          | Bin 8437 -> 8504 bytes
>  tests/data/acpi/x86/pc/DSDT.acpihmat          | Bin 9851 -> 9918 bytes
>  tests/data/acpi/x86/pc/DSDT.bridge            | Bin 15397 -> 15464 bytes
>  tests/data/acpi/x86/pc/DSDT.cphp              | Bin 8990 -> 9057 bytes
>  tests/data/acpi/x86/pc/DSDT.dimmpxm           | Bin 10180 -> 10247 bytes
>  tests/data/acpi/x86/pc/DSDT.hpbridge          | Bin 8477 -> 8544 bytes
>  tests/data/acpi/x86/pc/DSDT.hpbrroot          | Bin 5033 -> 5100 bytes
>  tests/data/acpi/x86/pc/DSDT.ipmikcs           | Bin 8598 -> 8665 bytes
>  tests/data/acpi/x86/pc/DSDT.memhp             | Bin 9885 -> 9952 bytes
>  tests/data/acpi/x86/pc/DSDT.nohpet            | Bin 8384 -> 8451 bytes
>  tests/data/acpi/x86/pc/DSDT.numamem           | Bin 8532 -> 8599 bytes
>  tests/data/acpi/x86/pc/DSDT.roothp            | Bin 12319 -> 12386 bytes
>  tests/data/acpi/x86/q35/DSDT                  | Bin 8355 -> 8422 bytes
>  tests/data/acpi/x86/q35/DSDT.acpierst         | Bin 8372 -> 8439 bytes
>  tests/data/acpi/x86/q35/DSDT.acpihmat         | Bin 9680 -> 9747 bytes
>  .../data/acpi/x86/q35/DSDT.acpihmat-generic-x | Bin 12565 -> 12632 bytes
>  .../acpi/x86/q35/DSDT.acpihmat-noinitiator    | Bin 8634 -> 8701 bytes
>  tests/data/acpi/x86/q35/DSDT.applesmc         | Bin 8401 -> 8468 bytes
>  tests/data/acpi/x86/q35/DSDT.bridge           | Bin 11968 -> 12035 bytes
>  tests/data/acpi/x86/q35/DSDT.core-count       | Bin 12913 -> 12980 bytes
>  tests/data/acpi/x86/q35/DSDT.core-count2      | Bin 33770 -> 33837 bytes
>  tests/data/acpi/x86/q35/DSDT.cphp             | Bin 8819 -> 8886 bytes
>  tests/data/acpi/x86/q35/DSDT.cxl              | Bin 13146 -> 13213 bytes
>  tests/data/acpi/x86/q35/DSDT.dimmpxm          | Bin 10009 -> 10076 bytes
>  tests/data/acpi/x86/q35/DSDT.ipmibt           | Bin 8430 -> 8497 bytes
>  tests/data/acpi/x86/q35/DSDT.ipmismbus        | Bin 8443 -> 8510 bytes
>  tests/data/acpi/x86/q35/DSDT.ivrs             | Bin 8372 -> 8439 bytes
>  tests/data/acpi/x86/q35/DSDT.memhp            | Bin 9714 -> 9781 bytes
>  tests/data/acpi/x86/q35/DSDT.mmio64           | Bin 9485 -> 9552 bytes
>  tests/data/acpi/x86/q35/DSDT.multi-bridge     | Bin 13208 -> 13275 bytes
>  tests/data/acpi/x86/q35/DSDT.noacpihp         | Bin 8235 -> 8302 bytes
>  tests/data/acpi/x86/q35/DSDT.nohpet           | Bin 8213 -> 8280 bytes
>  tests/data/acpi/x86/q35/DSDT.numamem          | Bin 8361 -> 8428 bytes
>  tests/data/acpi/x86/q35/DSDT.pvpanic-isa      | Bin 8456 -> 8523 bytes
>  tests/data/acpi/x86/q35/DSDT.thread-count     | Bin 12913 -> 12980 bytes
>  tests/data/acpi/x86/q35/DSDT.thread-count2    | Bin 33770 -> 33837 bytes
>  tests/data/acpi/x86/q35/DSDT.tis.tpm12        | Bin 8961 -> 9028 bytes
>  tests/data/acpi/x86/q35/DSDT.tis.tpm2         | Bin 8987 -> 9054 bytes
>  tests/data/acpi/x86/q35/DSDT.type4-count      | Bin 18589 -> 18656 bytes
>  tests/data/acpi/x86/q35/DSDT.viot             | Bin 14612 -> 14679 bytes
>  tests/data/acpi/x86/q35/DSDT.xapic            | Bin 35718 -> 35785 bytes
>  43 files changed, 34 insertions(+), 9 deletions(-)
> 
> -- 
> 2.43.0

Eric Mackay Dec. 18, 2024, 5:10 p.m. UTC | #2

Tested-by: Eric Mackay <eric.mackay@oracle.com>