mbox series

[v4,0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

Message ID 20250115-glib-v4-0-a827b2676259@daynix.com (mailing list archive)
Headers show
Series tap: Use g_spawn_sync() and g_spawn_check_wait_status() | expand

Message

Akihiko Odaki Jan. 15, 2025, 12:03 p.m. UTC 
g_spawn_sync() gives an informative message if it fails to execute
the script instead of reporting exiting status 1.

g_spawn_check_wait_status() also gives an message easier to understand
than the raw value returned by waitpid().

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Changes in v4:
- Changed to use g_spawn_async_with_pipes_and_fds() when available.
  (Daniel P. Berrangé)
- Link to v3: https://lore.kernel.org/r/20250115-glib-v3-0-bd3153344698@daynix.com

Changes in v3:
- Added GLIB_CHECK_VERSION(2, 70, 0) for patch "glib-compat: Define
  g_spawn_check_wait_status()". (Daniel P. Berrangé)
- Link to v2: https://lore.kernel.org/r/20250104-glib-v2-0-12013f3e5782@daynix.com

Changes in v2:
- Rebased.
- Link to v1: https://lore.kernel.org/r/20231219-glib-v1-0-1b040d286b91@daynix.com

---
Akihiko Odaki (2):
      glib-compat: Define g_spawn_check_wait_status()
      tap: Use g_spawn_sync() and g_spawn_check_wait_status()

 include/glib-compat.h |  11 +++
 net/tap.c             | 220 +++++++++++++++++++++++++++-----------------------
 2 files changed, 128 insertions(+), 103 deletions(-)
---
base-commit: 38d0939b86e2eef6f6a622c6f1f7befda0146595
change-id: 20231219-glib-034a34bb05d8

Best regards,