From patchwork Wed Jan 22 13:43:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 13947293 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 935F4C02182 for ; Wed, 22 Jan 2025 13:44:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tab0z-0005XS-S5; Wed, 22 Jan 2025 08:43:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tab0v-0005Un-OZ for qemu-devel@nongnu.org; Wed, 22 Jan 2025 08:43:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tab0t-0007Ec-D0 for qemu-devel@nongnu.org; Wed, 22 Jan 2025 08:43:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737553402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tjLWfYooEnQK6lmmTPjkWLL50UF4YRt1NJopOsS01VY=; b=Ze8rxcBvsKrmYYm0Vgc0RQ3R0MiAAKSO580NWP6OPZBnK7kQaV/cQvK90fCGzi0TPoyMdY RW960LqMCsTHkGBGHXYlSmxM5Zvo124cWdMMEbCAaXZaHwkfoEf8/SQ1D3FYtnBla+MMFv 8WY72cgWGXcvLpLKswhv9OgRQcgEeMY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-6L2gC5KvO6avOmgJyhDoUQ-1; Wed, 22 Jan 2025 08:43:19 -0500 X-MC-Unique: 6L2gC5KvO6avOmgJyhDoUQ-1 X-Mimecast-MFC-AGG-ID: 6L2gC5KvO6avOmgJyhDoUQ Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68955195604F; Wed, 22 Jan 2025 13:43:18 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.246]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 11DEF195E3DE; Wed, 22 Jan 2025 13:43:16 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, "Daniel P . Berrange" Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 0/2] tests/functional: Fix broken decorators Date: Wed, 22 Jan 2025 14:43:12 +0100 Message-ID: <20250122134315.1448794-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.043, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Many of the new decorators of the functional tests don't work as expected (and simply always allow to run the tests). Let's fix them! v2: - Use importlib.import_module() to check whether we can import a module - Split the import check into a separate patch Thomas Huth (2): tests/functional/qemu_test/decorators: Fix bad check for imports tests/functional: Fix broken decorators with lamda functions tests/functional/qemu_test/decorators.py | 45 ++++++++++++------------ 1 file changed, 22 insertions(+), 23 deletions(-)