mbox series

[v3,0/1] fallocate missing fd_offset

Message ID 20250122194053.3103617-1-william.roche@oracle.com (mailing list archive)
Headers show
Series fallocate missing fd_offset | expand

Message

“William Roche Jan. 22, 2025, 7:40 p.m. UTC 
From: William Roche <william.roche@oracle.com>

Working on the poisoned memory recovery mechanisms with David
Hildenbrand, it appeared that the file hole punching done with
the memory discard functions are missing the file offset value
fd_offset to correctly modify the right file location.

Note that guest_memfd would not currently take into account
fd_offset, so I'm adding a comment next the the fallocate use
in ram_block_discard_guest_memfd_range().

The version is also checkpatch.pl clean
make check runs fine on both ARM and x86

v1->v2
  . replacing the ram_block_discard_guest_memfd_range()
    modifications with a comment.
  . use a local variable for the global file offset

v2->v3
  . change the error reporting messages separating start and fd_offset
  . the local variable is no longer needed


William Roche (1):
  system/physmem: take into account fd_offset for file fallocate

 system/physmem.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)