mbox series

[v3,0/4] qapi/machine: Make @dump-skeys command generic

Message ID 20250310151414.11550-1-philmd@linaro.org (mailing list archive)
Headers show
Series qapi/machine: Make @dump-skeys command generic | expand

Message

Philippe Mathieu-Daudé March 10, 2025, 3:14 p.m. UTC 
We are trying to unify all qemu-system-FOO to a single binary.
In order to do that we need to remove QAPI target specific code.

Introduce the TYPE_DUMP_SKEYS_INTERFACE type which provide the
qmp_dump_skeys() callback, have it implemented on the CCW machine.
Machines not supporting this interface report a QMP GenericError.
No HMP change.

Since v2:
- Use machine interface (Daniel)

Since v1 [*]:
- No QMP rename / deprecation

[*] https://lore.kernel.org/qemu-devel/20240530074544.25444-1-philmd@linaro.org/

Philippe Mathieu-Daudé (4):
  hw/s390x/skeys: Declare QOM types using DEFINE_TYPES() macro
  hw/s390x/skeys: Introduce TYPE_DUMP_SKEYS_INTERFACE
  hw/s390x/ccw: Have CCW machine implement a qmp_dump_skeys() callback
  qapi/machine: Make @dump-skeys command generic

 qapi/machine.json               | 18 +++++++++++++
 qapi/misc-target.json           | 19 -------------
 include/hw/s390x/storage-keys.h | 16 +++++++++++
 hw/core/machine-qmp-cmds.c      | 14 ++++++++++
 hw/s390x/s390-skeys.c           | 47 +++++++++++++++++----------------
 hw/s390x/s390-virtio-ccw.c      |  3 +++
 6 files changed, 75 insertions(+), 42 deletions(-)