From patchwork Mon Mar 17 02:29:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bibo Mao X-Patchwork-Id: 14018593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D295C28B2F for ; Mon, 17 Mar 2025 02:30:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tu0EQ-0002vv-C0; Sun, 16 Mar 2025 22:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tu0EN-0002vb-Ot for qemu-devel@nongnu.org; Sun, 16 Mar 2025 22:29:31 -0400 Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tu0EL-00031x-6Q for qemu-devel@nongnu.org; Sun, 16 Mar 2025 22:29:31 -0400 Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8CxieADiddnqU+ZAA--.18862S3; Mon, 17 Mar 2025 10:29:23 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by front1 (Coremail) with SMTP id qMiowMCxbsUDiddn1ZVOAA--.28932S2; Mon, 17 Mar 2025 10:29:23 +0800 (CST) From: Bibo Mao To: Song Gao Cc: Jiaxun Yang , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini Subject: [PATCH v3 0/3] target/loongarch: Solve some issues reported from coccinelle Date: Mon, 17 Mar 2025 10:29:19 +0800 Message-Id: <20250317022922.802988-1-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-CM-TRANSID: qMiowMCxbsUDiddn1ZVOAA--.28932S2 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Received-SPF: pass client-ip=114.242.206.163; envelope-from=maobibo@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This patch set solves errors reported by coccinelle tool with commands: spatch --sp-file scripts/coccinelle/*.cocci --dir target/loongarch/ spatch --sp-file scripts/coccinelle/*.cocci --dir hw/loongarch/ The main problem is that qemu should fail to run when feature is forced to enabled however KVM does not support it, rather than report error and continue to run. --- v2 ... v3: 1. Add missing modification replacing error_propagate() + error_setg() with error_setg(). 2. Some enhancement about error handling, handling error symmetrically in many places v1 ... v2: 1. Add fixes tag and change title with fix prefix in patch 1. 2. Replace error_propagate() with error_setg(), and return directly for any error. --- Bibo Mao (3): target/loongarch: Fix error handling of KVM feature checks hw/loongarch/virt: Remove unnecessary NULL pointer target/loongarch: Remove unnecessary temporary variable assignment hw/loongarch/virt.c | 28 +++++++++++----------------- target/loongarch/kvm/kvm.c | 8 ++++++-- target/loongarch/tcg/tlb_helper.c | 5 ++--- 3 files changed, 19 insertions(+), 22 deletions(-) base-commit: aa90f1161bb17a4863e16ec2f75104cff0752d4e